Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyre 0.9.22 (new formula) #195001

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Anselmoo
Copy link
Contributor

@Anselmoo Anselmoo commented Oct 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Oct 20, 2024
@Anselmoo
Copy link
Contributor Author

@carlocab Sorry, can I ask you what is the current best approach to deal with the CPU issue

ƛ [Errno 86] Bad CPU type in executable: '/opt/homebrew/bin/pyre.bin' 

Locally it is working fine:

image

Formula/p/pyre.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 21, 2024
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 21, 2024
@chenrui333
Copy link
Member

@carlocab Sorry, can I ask you what is the current best approach to deal with the CPU issue

ƛ [Errno 86] Bad CPU type in executable: '/opt/homebrew/bin/pyre.bin' 

Locally it is working fine:

image

this is the upstream issue, facebook/pyre-check#614

@chenrui333 chenrui333 added upstream issue An upstream issue report is needed build failure CI fails while building the software labels Oct 21, 2024
@chenrui333
Copy link
Member

after another look, you might need to build pyre.bin with ocaml toolchain, you can check https://github.com/nix-windows/nixpkgs/blob/dc7ea0147fc07a391d15564e5f133e81095d57f4/pkgs/development/tools/pyre/default.nix setup for ref.

@Anselmoo
Copy link
Contributor Author

after another look, you might need to build pyre.bin with ocaml toolchain, you can check https://github.com/nix-windows/nixpkgs/blob/dc7ea0147fc07a391d15564e5f133e81095d57f4/pkgs/development/tools/pyre/default.nix setup for ref.

thx @chenrui333 for your research

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants