Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stella 7.0c #205268

Merged
merged 2 commits into from
Jan 24, 2025
Merged

stella 7.0c #205268

merged 2 commits into from
Jan 24, 2025

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 23, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 23, 2025
@chenrui333 chenrui333 force-pushed the stella-7.0c branch 2 times, most recently from 42f4b76 to 3c107b9 Compare January 23, 2025 06:07
@chenrui333 chenrui333 marked this pull request as draft January 23, 2025 06:20
This was referenced Jan 23, 2025
Open
Merged
@chenrui333 chenrui333 marked this pull request as ready for review January 23, 2025 06:46
@stefanb stefanb mentioned this pull request Jan 23, 2025
Closed
@chenrui333
stella 7.0c
ab277b7 
Signed-off-by: Rui Chen <[email protected]>

stella: revert `Convert stringstream::view()` to `stringstream::str()` for ventura builds

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 23, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 23, 2025 23:55
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit 2485a82 Jan 24, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the stella-7.0c branch January 24, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @daeho-ro @BrewTestBot