envoy 1.33.0 #205269
envoy 1.33.0 #205269
Conversation
github-actions
bot
added
CI-linux-self-hosted
|
Failures both in CI and on Apple Silicon (my laptop) Linux Apple Silicon Laptop |
|
@zirain I saw you ran into this in istio. If you have a chance, can you recommend any way to proceed this in homebrew for envoy? istio/proxy#5154 |
|
@codefromthecrypt I can build on my macm1(with clang 16). |
|
yep, clang version must be the old version like 14 or 16 (i think 14 is the one currently envoy is using for all platform (mac/ubuntu)) |
github-actions
bot
added
the
autosquash
|
@codefromthecrypt during my debuging on #205289, looks like this related to curl upgrade from 8.4 to 8.9, not 100% sure about it, hope this give you some hint. I cannot set up a test locally, as my ruby broken on my mac. |
|
Envoy could just disable curl man pages ( Footnotes |
codefromthecrypt
force-pushed
the
envoy-1.33.0
branch
from
fb190b4 to
e5fd03c
Compare
github-actions
bot
removed
the
autosquash
codefromthecrypt
force-pushed
the
envoy-1.33.0
branch
from
e5fd03c to
1fe8ceb
Compare
This should be turned off as it's not needed. Ref Homebrew/homebrew-core#205269 Fix #37470 Signed-off-by: Takeshi Yoneda <[email protected]>
cho-m
added
the
CI-no-fail-fast
cho-m
force-pushed
the
envoy-1.33.0
branch
2 times, most recently
from
e62d400 to
c185ca6
Compare
|
ARM macOS passes. Linux is going to take some time to start but based on prior run (https://github.com/Homebrew/homebrew-core/actions/runs/12942003180/job/36099164302#step:4:352) it will fail: Closest upstream reports were:
Not sure but guessing that compiling with LLVM Clang and linking to GCC libstdc++ isn't behaving well in newer Envoy versions (or newer versions of Clang may have elevated warning to error). In Homebrew, build:libc++ --action_env=BAZEL_LINKLIBS=-l%:libc++.a:-l%:libc++abi.aEDIT: If error still occurs, could try reducing error. May also want to check if issue with GCC still occurs (I had to switch build to clang/lld back in https://github.com/Homebrew/homebrew-core/pull/166177/files) |
codefromthecrypt
force-pushed
the
envoy-1.33.0
branch
from
c185ca6 to
4ec9dd3
Compare
|
@cho-m thanks for the help and I hope I didn't lose any of your work on rebase. Ack that disabling libcurl docs and removing installation of examples worked for me locally. FWIW macOS is the most important OS to have working, but also ideal if we can keep linux working also. Great job so far! |
|
@zirain this is mostly a self-note for me in case we force push it out later on envoy-1.33.1, but I often forget patch syntax here and we occasionally need it for envoy. Here's what's working to use something not landed, yet. stable do
url "https://github.com/envoyproxy/envoy/archive/refs/tags/v1.33.0.tar.gz"
sha256 "fd726135761ea163f0312d49960c602c9b4fcb78ca3c36600975fed16e0787c4"
# Backport disabling libcurl docs to fix build. Remove in the next release.
patch do
url "https://github.com/envoyproxy/envoy/commit/ae6cb3254cbf98999993d0120d289a207a57f825.patch?full_index=1"
sha256 "a5c25bad6884f382909036ac9e8c812c5d3ba3104f2f1d24f5035acf705b0d74"
end
end |
github-actions
bot
added
the
autosquash
|
there is a fix for the curl/docs/compiler issue on envoy |
Signed-off-by: Adrian Cole <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]>
github-actions
bot
removed
the
autosquash
|
fantastic - it's workign! |
|
thrilling teamwork. Thanks all and esp @phlax for making sure these things get scrubbed out on subsequent patch releases, too! |
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
🏅 |
This should be turned off as it's not needed. Ref Homebrew/homebrew-core#205269 Fix envoyproxy#37470 Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
This should be turned off as it's not needed. Ref Homebrew/homebrew-core#205269 Fix envoyproxy#37470 Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
This should be turned off as it's not needed. Ref Homebrew/homebrew-core#205269 Fix #37470 Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
This should be turned off as it's not needed. Ref Homebrew/homebrew-core#205269 Fix #37470 Signed-off-by: Takeshi Yoneda <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
This should be turned off as it's not needed. Ref Homebrew/homebrew-core#205269 Fix envoyproxy#37470 Signed-off-by: Takeshi Yoneda <[email protected]>
| @@ -51,21 +62,32 @@ def install | |||
| --verbose_failures | |||
| --action_env=PATH=#{env_path} | |||
| --host_action_env=PATH=#{env_path} | |||
| --define=wasm=disabled | |||
There was a problem hiding this comment.
is this means wasm was totally disabled?
There was a problem hiding this comment.
Maybe @mathetake can clarify, but iirc before it wasn't built on Darwin and now (here in this formula) also in linux
There was a problem hiding this comment.
wasm=v8 can be restored but Homebrew needs a backport of v8/v8@c814d86 (specifically we need -Wno-cast-function-type-mismatch for Clang 19) in a Bazel-applied patch file like https://github.com/envoyproxy/envoy/blob/main/bazel/v8.patch
There was a problem hiding this comment.
we are currently working on updating llvm in envoy - current target is 18.x, but would be happy to review any fixes to make 19+ work
There was a problem hiding this comment.
Homebrew needs a backport
apologies i just read your comment properly
i think we would be less inclined to backport fixes for this to other branches in envoy - simply because there are a bunch of known issues that would need to be addressed to make earlier branches work with llvm > 14
There was a problem hiding this comment.
Backport patch for v8 code base.
To be specific, it may be something like:
diff --git a/bazel/v8.patch b/bazel/v8.patch
index 2d7101db91..32de7740c6 100644
--- a/bazel/v8.patch
+++ b/bazel/v8.patch
@@ -103,3 +103,15 @@ index c3768b8..d4a1dda 100755
import pdl
try:
+diff --git a/bazel/defs.bzl b/bazel/defs.bzl
+index e957c0f..a5d142c 100644
+--- a/bazel/defs.bzl
++++ b/bazel/defs.bzl
+@@ -104,6 +104,7 @@ def _default_args():
+ "-Werror",
+ "-Wextra",
+ "-Wno-unknown-warning-option",
++ "-Wno-cast-function-type-mismatch",
+ "-Wno-bitwise-instead-of-logical",
+ "-Wno-builtin-assume-aligned-alignment",
+ "-Wno-unused-parameter",There was a problem hiding this comment.
for those following along, when you discuss possibility of restoring with some backport, etc. work, you are referring to restoring linux only, or also macOS?
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?