-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: patch bazel for macOS 10.12 Sierra #5270
Conversation
I think I'd like to wait on a new release here... CC @damieng for thoughts |
Nice, but you need to put it into a stable block: desc "Google's own build tool"
homepage "https://www.bazel.io/"
head "https://github.com/bazelbuild/bazel.git"
stable do
url "https://github.com/bazelbuild/bazel/archive/0.3.1.tar.gz"
sha256 "52beafc9d78fc315115226f31425e21df1714d96c7dfcdeeb02306e2fe028dd8"
# Fix build on macOS 10.12 Sierra
patch do
url "https://github.com/bazelbuild/bazel/commit/fefd2329f4812bcb513294fdf417fc726a86ddfd.diff"
sha256 "73455ede4acb9e40923838cb66750a5baacc6b6f8eaaeed72df02dbca38bbe73"
end
end
bottle do
cellar :any_skip_relocation
sha256 "fda77dc7aa1722d9586ec0a4148357ba89436d641c278e7a93da2486ba059059" => :el_capitan
sha256 "0fcea9e375d29bda7c7e291172cd59d235512952a377f469e684315c109f6dfb" => :yosemite
end |
Placed the patch in the |
* Wrap in stable block * Use nanosleep(2) instead of poll(2) to sleep * See bazelbuild/bazel@fefd232
I think I'd like to wait on a new release here... CC @damienmg for thoughts |
We just pushed a canary today. We have a 1 week baking but we are basically blocking on a couple of bugfixes. I still believe we should be able to release by next tuesday. |
Next Tuesday is a week from now, and bazel is popular enough to be on my #4841 list. What about we ship the patch now so people at least have something to work with. |
This patch is pretty much harmless and fixes the sierra issue so SGTM |
@ilovezfs I'll leave the decision to you. |
If @damienmg is happy to ⛵ then no objection from me! |
|
@ed-flanagan thanks for your contribution to Homebrew! 🎉 |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --new-formula <formula>
(after doingbrew install <formula>
)?bazelbuild/bazel@fefd232
Referenced: