Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: patch bazel for macOS 10.12 Sierra #5270

Closed
wants to merge 1 commit into from
Closed

bazel: patch bazel for macOS 10.12 Sierra #5270

wants to merge 1 commit into from

Conversation

ed-flanagan
Copy link
Contributor

@ed-flanagan ed-flanagan commented Sep 26, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?


Referenced:

@ilovezfs
Copy link
Contributor

I think I'd like to wait on a new release here... CC @damieng for thoughts

@zmwangx
Copy link
Contributor

zmwangx commented Sep 26, 2016

Nice, but you need to put it into a stable block:

  desc "Google's own build tool"
  homepage "https://www.bazel.io/"
  head "https://github.com/bazelbuild/bazel.git"

  stable do
    url "https://github.com/bazelbuild/bazel/archive/0.3.1.tar.gz"
    sha256 "52beafc9d78fc315115226f31425e21df1714d96c7dfcdeeb02306e2fe028dd8"

    # Fix build on macOS 10.12 Sierra
    patch do
      url "https://github.com/bazelbuild/bazel/commit/fefd2329f4812bcb513294fdf417fc726a86ddfd.diff"
      sha256 "73455ede4acb9e40923838cb66750a5baacc6b6f8eaaeed72df02dbca38bbe73"
    end
  end

  bottle do
    cellar :any_skip_relocation
    sha256 "fda77dc7aa1722d9586ec0a4148357ba89436d641c278e7a93da2486ba059059" => :el_capitan
    sha256 "0fcea9e375d29bda7c7e291172cd59d235512952a377f469e684315c109f6dfb" => :yosemite
  end

@ed-flanagan
Copy link
Contributor Author

Placed the patch in the stable block.

* Wrap in stable block
* Use nanosleep(2) instead of poll(2) to sleep
* See
  bazelbuild/bazel@fefd232
@ilovezfs
Copy link
Contributor

I think I'd like to wait on a new release here... CC @damienmg for thoughts

@damienmg
Copy link
Contributor

We just pushed a canary today. We have a 1 week baking but we are basically blocking on a couple of bugfixes. I still believe we should be able to release by next tuesday.

@zmwangx
Copy link
Contributor

zmwangx commented Sep 28, 2016

Next Tuesday is a week from now, and bazel is popular enough to be on my #4841 list. What about we ship the patch now so people at least have something to work with.

@damienmg
Copy link
Contributor

This patch is pretty much harmless and fixes the sierra issue so SGTM

@zmwangx
Copy link
Contributor

zmwangx commented Sep 28, 2016

@ilovezfs I'll leave the decision to you.

@ilovezfs
Copy link
Contributor

If @damienmg is happy to ⛵ then no objection from me!

@zmwangx
Copy link
Contributor

zmwangx commented Sep 28, 2016

:shipit:

@ilovezfs ilovezfs closed this in 901d299 Sep 28, 2016
@ilovezfs
Copy link
Contributor

@ed-flanagan thanks for your contribution to Homebrew! 🎉

@ed-flanagan ed-flanagan deleted the bazel-patch-sierra branch November 13, 2016 22:26
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants