Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gsoap to version 2.8.36 #5549

Closed
wants to merge 3 commits into from
Closed

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Oct 3, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

@ilovezfs ilovezfs added the CI-requeued PR has been re-added to the queue label Oct 11, 2016
@@ -15,12 +15,6 @@ class Gsoap < Formula
def install
ENV.deparallelize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you see if this is still needed and, if so, report an issue upstream?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still needed. I contacted upstream via email, it's the only contact method I've found on their website.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disappointing but thanks for checking. Could you add a Ruby inline comment just noting when you contacted them, how and what they said (abbreviated version; a line or two max). Thanks!

@dunn
Copy link
Contributor

dunn commented Oct 19, 2016

This needs to be rebased now, sorry!

@dunn dunn added the needs response Needs a response from the issue/PR author label Oct 19, 2016
* Bumped to version 2.8.36
* Removed the two inreplace that were no longer necessary
* Updated the homepage
* Fixed the bottle issue on Sierra
@BrewTestBot BrewTestBot removed the needs response Needs a response from the issue/PR author label Oct 19, 2016
@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-requeued PR has been re-added to the queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants