needle 0.18.1

[cho-m]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[SMillerDev]

Can we not patch make to build the correct one here?

[cho-m]

Makefile copies library from Xcode.app (https://github.com/uber/needle/blob/v0.17.2/Makefile#L49) and then just modifies RPATH.

[SMillerDev]

I don't think that allows us to ship it since XCode is proprietary

[SMillerDev]

We could use the one from the swift formula though. That is guaranteed open source

[cho-m]

I'll give that a try.

[cho-m]

Looks like swift might be taking over build from Xcode and causing some issues.

[Bo98]

There is a reason it ships with Xcode rather than the OS. lib_InternalSwiftSyntaxParser must match the Swift version used to compile. We ship Swift 5.6 so using that dylib but still compiling using whatever older Swift version ships with older Xcodes could cause problems:

You can either copy lib_InternalSwiftSyntaxParser.dylib/.so directly from the toolchain or even build it yourself from the Swift repository, as long as you are matching the same tags or branches in both the SwiftSyntax and Swift repositories.

https://github.com/apple/swift-syntax/blob/e22754fbe767bfb290199573309689acb24297ef/Documentation/README.md#embedding-swiftsyntax-in-an-application

[cho-m]

I think the Makefile directly runs swift commands, so it might not be using Xcode in current state. Locally, I could build via Rosetta but not natively on M1.

Is there any extra licensing terms to allow us to just use pre-built from Xcode toolchain? I think that would reduce breakages as upstream will follow Xcode releases.

[Bo98]

Is there any extra licensing terms to allow us to just use pre-built from Xcode toolchain?

We've done stuff like that before, like JavaNativeFoundation in openjdk@11. Sean raises a fair point but I don't really have the answer to it, because no one has really properly raised it or looked into it until now.

[SMillerDev]

Filed: uber/needle#412

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.