Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plist over rexml #599

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Use plist over rexml #599

merged 1 commit into from
Oct 28, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 28, 2023

REXML is disappearing in Ruby 3 and will move to Homebrew/brew's Gemfile. At this time there are no plans to commit it to the repository as a vendored gem and brew services should work without needing to install any extra gems. plist is however already there as a committed vendored gem so we can use that. It also has better API.

I haven't tested the --sudo-service-user part of this. @MikeMcQuaid you're likely best positioned to test that.

@Bo98 Bo98 requested a review from MikeMcQuaid October 28, 2023 00:43
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit c17b19e into Homebrew:master Oct 28, 2023
@Bo98 Bo98 deleted the no-rexml branch October 28, 2023 18:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants