Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH M1.1 #2

Merged
merged 9 commits into from
Mar 28, 2024
Merged

NH M1.1 #2

merged 9 commits into from
Mar 28, 2024

Conversation

MarcoOl94
Copy link

No description provided.

ysibirski
ysibirski requested changes Mar 26, 2024
View reviewed changes
Copy link

@ysibirski ysibirski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small additions for NGINX config

test/config/nginx/templates/default.conf.tmpl Show resolved Hide resolved
lander86
lander86 approved these changes Mar 27, 2024
View reviewed changes
Copy link

@lander86 lander86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lander86 lander86 requested a review from ysibirski March 27, 2024 11:23
ysibirski
ysibirski requested changes Mar 27, 2024
View reviewed changes
Copy link

@ysibirski ysibirski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change under nginx config is required

ysibirski
ysibirski approved these changes Mar 28, 2024
View reviewed changes
Copy link

@ysibirski ysibirski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoOl94 MarcoOl94 requested review from ysibirski and removed request for cronicc March 28, 2024 15:34
@MarcoOl94 MarcoOl94 merged commit 73b2351 into main-hl Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lander86 lander86 lander86 approved these changes

@ysibirski ysibirski Awaiting requested review from ysibirski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoOl94 @ysibirski @lander86