The nuplan v1.3rc #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemonswx
reviewed
Jul 12, 2024
JingyuQian
force-pushed
the
closed-loop-merge
branch
2 times, most recently
from
7630970 to
dc2d55d
Compare
JingyuQian
force-pushed
the
closed-loop-merge
branch
from
dc2d55d to
dbbd9ec
Compare
| @@ -132,57 +123,10 @@ def build_trainer(cfg: DictConfig) -> pl.Trainer: | |||
| params = cfg.lightning.trainer.params | |||
|
|
|||
| callbacks = build_callbacks(cfg) | |||
|
|
|||
| plugins = [ | |||
There was a problem hiding this comment.
去掉这些plugins和loggers是因为什么？是已经在callbacks里了？
There was a problem hiding this comment.
是已经在默认的trainer设置里面了，所以这些就不需要了
| @@ -34,16 +34,6 @@ def update_config_for_training(cfg: DictConfig) -> None: | |||
|
|
|||
| Path(cfg.cache.cache_path).mkdir(parents=True, exist_ok=True) | |||
|
|
|||
| if cfg.lightning.trainer.overfitting.enable: | |||
There was a problem hiding this comment.
这个功能很少用到，所以就去掉了。想要的话我可以在trainer里面加一个overfit_batches的key，直接控制trainer
JingyuQian
force-pushed
the
closed-loop-merge
branch
from
dbbd9ec to
4470793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the nuplan devkit v1.3rc, a custom-maintained version of nuplan that features some latest developments of pytorch, pytorch-lightning and other dependent libraries.