Merge pull request #929 from HubSpot/br-safer-project-structure-lookup

Validate paths before generating card config paths
HubSpot · Aug 31, 2023 · de416e3 · de416e3
2 parents 50781b4 + b398765
commit de416e3
Showing 1 changed file with 16 additions and 12 deletions.
diff --git a/packages/cli/lib/projectStructure.js b/packages/cli/lib/projectStructure.js
@@ -32,11 +32,13 @@ function getAppCardConfigs(appConfig, appPath) {
 
   if (cards) {
     cards.forEach(({ file }) => {
-      const cardConfigPath = path.join(appPath, file);
-      const cardConfig = loadConfigFile(cardConfigPath);
+      if (typeof file === 'string') {
+        const cardConfigPath = path.join(appPath, file);
+        const cardConfig = loadConfigFile(cardConfigPath);
 
-      if (cardConfig) {
-        cardConfigs.push(cardConfig);
+        if (cardConfig) {
+          cardConfigs.push(cardConfig);
+        }
       }
     });
   }
@@ -84,14 +86,16 @@ async function findProjectComponents(projectSourceDir) {
           0,
           projectFile.indexOf(APP_COMPONENT_CONFIG)
         );
-        const isLegacy = getIsLegacyApp(parsedAppConfig, appPath);
-
-        components.push({
-          type: COMPONENT_TYPES.app,
-          config: parsedAppConfig,
-          runnable: !isLegacy,
-          path: appPath,
-        });
+        if (typeof appPath === 'string') {
+          const isLegacy = getIsLegacyApp(parsedAppConfig, appPath);
+
+          components.push({
+            type: COMPONENT_TYPES.app,
+            config: parsedAppConfig,
+            runnable: !isLegacy,
+            path: appPath,
+          });
+        }
       }
     }
   });