Remove support for portal env variable #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
|
Ok Slight pivot, my latest changes make This is what will show |
camden11
previously approved these changes
Jan 10, 2025
kemmerle
reviewed
Jan 10, 2025
kemmerle
reviewed
Jan 10, 2025
kemmerle
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Issue: #1327
In CLI release 7.0.0 we've moved away from referring to hubspot accounts as "portals" in favor of "account". This is a move that we've been slowly moving towards for a while now.
There was an issue with
HUBSPOT_ACCOUNT_IDnot working correctly that's fixed by HubSpot/hubspot-local-dev-lib#225This also adds a message for folks who are still using
HUBSPOT_PORTAL_IDScreenshots
TODO
Who to Notify