Add Example to Crm Data Components to Demonstrate CrmCardActions & CrmActionButton
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aanchalHS you were listed as a suggested reviewer for this PR, but please feel free to tag someone else if this recommendation was incorrect! |
deidrakandra
approved these changes
Apr 26, 2024
Comment on lines
+17
to
+23
| hubspot.extend(({ context, runServerlessFunction, actions }) => ( | ||
| <Extension | ||
| context={context} | ||
| runServerless={runServerlessFunction} | ||
| sendAlert={actions.addAlert} | ||
| /> | ||
| )); |
There was a problem hiding this comment.
Probably don't need these if they aren't being used in your extension?
Suggested change
| hubspot.extend(({ context, runServerlessFunction, actions }) => ( | |
| <Extension | |
| context={context} | |
| runServerless={runServerlessFunction} | |
| sendAlert={actions.addAlert} | |
| /> | |
| )); | |
| hubspot.extend(({ context }) => ( | |
| <Extension | |
| context={context} | |
| /> | |
| )); |
There was a problem hiding this comment.
It looks like all three props are required for Extension per its type. Even though they're not used, we may still want to leave them to prevent TS errors
| ]; | ||
|
|
||
| const Extension = ({ context, runServerless, sendAlert }) => { | ||
| const [scenario, setScenario] = useState<any>("engagement"); |
There was a problem hiding this comment.
Should this be a string if using ts?
Suggested change
| const [scenario, setScenario] = useState<any>("engagement"); | |
| const [scenario, setScenario] = useState<string>("engagement"); |
| const currentObjectId = context.crm.objectId; | ||
| const currentObjectTypeId = context.crm.objectTypeId; | ||
|
|
||
| const actionsToPropertiesMap = { |
There was a problem hiding this comment.
Might be worth wrapping this in a useMemo?
| </Text> | ||
|
|
||
| <Flex direction="row" align="end" gap="small"> | ||
| <Form> |
There was a problem hiding this comment.
Do you need a Form here?
- Add example of onError for CrmActionsButton - PR Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a new example for the
CrmCardActionsandCrmActionButtoncomponents withincrm-data-components. This new example is aCrmPropertyListthat dynamically changes the properties displayed and actions button based on a given scenario from a dropdown select. Updates theREADMEwith images and documentation as well.