Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade isomorphic-unfetch package from 4.0.2 to 4.0.0 #28

Merged

Conversation

TheLuckyLuc
Copy link
Contributor

v4.0.1 introduced a Module not found: Error: Can't resolve 'unfetch' in '/src/node_modules/isomorphic-unfetch' error when trying to compile projects using our updated @hubble/request package.

This was due to it using v5.0.0 of the unfetch package as a dependency, which has an invalid path export in its package.json. There's a PR for a fix submitted here, but it's been sitting there since 10/02/2023, so there's no telling how long this may take to be updated on their end.

Therefore, downgrading to v4.0.0 of isomorphic-unfetch ensures it uses v4.2.0 of unfetch, which doesn't seem to have this problem.

v4.0.1 introduced a "Module not found: Error: Can't resolve 'unfetch' in '/src/node_modules/isomorphic-unfetch'" error when trying to compile projects using our updated @hubble/request package. This was due to it using v5.0.0 of the `unfetch` package as a dependency, which has an invalid path export in its package.json.
There's a PR for a fix submitted, but as it's been sitting there since 10/02/2023, there's no telling how long this may take to be updated. Therefore, downgrading to v4.0.0 of `isomorphic-unfetch` ensures it uses v4.2.0 of `unfetch`, which doesn't seem to have this problem.
@shortcut-integration
Copy link

@TheLuckyLuc TheLuckyLuc merged commit 456dc41 into main Mar 16, 2023
@TheLuckyLuc TheLuckyLuc deleted the sc-9248-downgrade-isomorphic-unfetch-package-in-request branch March 16, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants