Merge branch 'master' into fb-leap-443/lsf-init

.github/workflows/build.yml

@@ -28,7 +28,7 @@ jobs:
       run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
 
     - name: Configure yarn cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
         key: ${{ env.CACHE_NAME_PREFIX }}-${{ runner.os }}-node-${{ env.NODE }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}

.github/workflows/eslint.yml

@@ -42,7 +42,7 @@ jobs:
         run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
 
       - name: Configure yarn cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
           key: ${{ env.CACHE_NAME_PREFIX }}-${{ runner.os }}-node-${{ env.NODE }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}

.github/workflows/git-command.yml

@@ -13,10 +13,16 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 3
     steps:
-      - name: Dump the client payload context
-        env:
-          PAYLOAD_CONTEXT: ${{ toJson(github.event.client_payload) }}
-        run: echo "$PAYLOAD_CONTEXT"
+      - uses: hmarr/[email protected]
+
+      - name: Add Workflow link to command comment
+        uses: peter-evans/create-or-update-comment@v4
+        with:
+          token: ${{ secrets.GIT_PAT }}
+          repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
+          comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
+          body: |
+            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
 
       - name: Checkout on chat command
         uses: actions/checkout@v4
@@ -27,28 +33,31 @@ jobs:
           submodules: 'recursive'
           fetch-depth: 0
 
+      - name: Configure git
+        shell: bash
+        run: |
+          set -xeuo pipefail
+          git config --global user.name '${{ github.event.client_payload.github.actor }}'
+          git config --global user.email '${{ github.event.client_payload.github.actor }}@users.noreply.github.com'
+
       - name: Check for merge conflict
         id: check-conflict
         env:
           SLASH_COMMAND_ARG_BRANCH: ${{ github.event.client_payload.slash_command.args.unnamed.arg2 }}
         shell: bash
         run: |
           set -xeuo pipefail
-          git config --global user.name '${{ github.event.client_payload.github.actor }}'
-          git config --global user.email '${{ github.event.client_payload.github.actor }}@users.noreply.github.com'
           echo "merge_conflict=$(git merge-tree $(git merge-base HEAD origin/$SLASH_COMMAND_ARG_BRANCH) origin/$SLASH_COMMAND_ARG_BRANCH HEAD | grep '<<')" >> $GITHUB_OUTPUT
 
       - name: Add reaction to command comment on merge conflict
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         if: ${{ steps.check-conflict.outputs.merge_conflict }}
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
           comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
           body: |
-            > **Error**: Merge conflict detected, please resolve it using the git command line.
-            >
-            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
+            > **Error**: Merge conflict detected, please resolve it using the command line.
           reactions: "-1"
 
       - name: Merge branch into current branch
@@ -72,42 +81,36 @@ jobs:
 
       - name: Add reaction to command comment on nothing to do
         if: ${{ !steps.check-conflict.outputs.merge_conflict && steps.commit_and_push.outputs.changes == 'no' }}
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
           comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
           body: |
             > Already up-to-date. Nothing to commit.
-            >
-            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
           reactions: "confused"
 
       - name: Add reaction to command comment on success
         if: ${{ !steps.check-conflict.outputs.merge_conflict && steps.commit_and_push.outputs.changes == 'yes' }}
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
           comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
           body: |
             > Successfully pushed new changes:
             > ${{ steps.commit_and_push.outputs.last_commit_msg }} (${{ steps.commit_and_push.outputs.last_commit_sha }})
-            >
-            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
           reactions: "+1"
 
       - name: Add reaction to command comment on failure
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         if: failure()
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
           comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
           body: |
             > **Error**: failed to execute "${{ github.event.client_payload.slash_command.args.unnamed.arg1 }}" command
-            >
-            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
           reactions: "-1"
 
   help:
@@ -116,7 +119,7 @@ jobs:
     timeout-minutes: 1
     steps:
       - name: Update comment
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}

.github/workflows/help-command.yml

@@ -10,7 +10,7 @@ jobs:
     steps:
       - name: Update comment if empty
         if: ${{ github.event.client_payload.slash_command.args.all == '' }}
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}

.github/workflows/jira-command.yml

@@ -1,4 +1,4 @@
-name: "/git command"
+name: "/jira command"
 
 on:
   repository_dispatch:
@@ -15,6 +15,15 @@ jobs:
     steps:
       - uses: hmarr/[email protected]
 
+      - name: Add Workflow link to command comment
+        uses: peter-evans/create-or-update-comment@v4
+        with:
+          token: ${{ secrets.GIT_PAT }}
+          repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
+          comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
+          body: |
+            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
+
       - name: Check user's membership
         uses: actions/github-script@v7
         id: check-membership
@@ -55,19 +64,17 @@ jobs:
           type: ${{ github.event.client_payload.slash_command.args.unnamed.arg2 || 'task' }}
 
       - name: Add reaction to command comment on success
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
           comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
           body: |
             > Jira issue [${{ steps.jira-create-issue.outputs.key }}](${{ steps.jira-create-issue.outputs.link }}) is created
-            >
-            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
           reactions: "+1"
 
       - name: Add reaction to command comment on failure
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         if: failure()
         with:
           token: ${{ secrets.GIT_PAT }}
@@ -76,7 +83,6 @@ jobs:
           body: |
             > **Error**: failed to execute "${{ github.event.client_payload.slash_command.args.unnamed.arg1 }}" command
             > ${{ steps.check-membership.outputs.error }}
-            > [Workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
           reactions: "-1"
 
   help:
@@ -85,7 +91,7 @@ jobs:
     timeout-minutes: 1
     steps:
       - name: Update comment
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           token: ${{ secrets.GIT_PAT }}
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}

.github/workflows/slash-command-dispatch.yml

@@ -9,6 +9,9 @@ env:
     git
     jira
 
+  issue_commands_list: |
+    jira
+
 jobs:
   slashCommandDispatch:
     if: startsWith(github.event.comment.body, '/')
@@ -22,38 +25,57 @@ jobs:
         uses: actions/github-script@v7
         env:
           COMMANDS_LIST: ${{ env.commands_list }}
+          ISSUE_COMMANDS_LIST: ${{ env.issue_commands_list }}
         with:
           github-token: ${{ secrets.GIT_PAT }}
           script: |
             const body = context.payload.comment.body.toLowerCase().trim()
             const commands_list = process.env.COMMANDS_LIST.split("\n")
+            const issue_commands_list = process.env.ISSUE_COMMANDS_LIST.split("\n")
             console.log("Detected PR comment: " + body)
             console.log("Commands list: " + commands_list)
+            console.log("Issue commands list: " + issue_commands_list)
             commandArray = body.split(/\s+/)
             const contextCommand = commandArray[0].split('/')[1].trim();
             console.log("contextCommand: " + contextCommand)
             core.setOutput('command_state', 'known')
+            core.setOutput('is_issue_command', 'false')
             if (! commands_list.includes(contextCommand)) {
               core.setOutput('command_state', 'unknown')
               core.setOutput('command', contextCommand)
             }
+            if (issue_commands_list.includes(contextCommand)) {
+              core.setOutput('is_issue_command', 'true')
+            }
+
+      - name: Slash Command Dispatch for Issues
+        id: scd_issues
+        if: ${{ steps.determine_command.outputs.command_state != 'unknown' && steps.determine_command.outputs.is_issue_command == 'true' }}
+        uses: peter-evans/slash-command-dispatch@v3
+        with:
+          token: ${{ secrets.GIT_PAT }}
+          reaction-token: ${{ secrets.GIT_PAT }}
+          issue-type: "issue"
+          reactions: true
+          commands: ${{ env.issue_commands_list }}
 
-      - name: Slash Command Dispatch
-        id: scd
-        if: ${{ steps.determine_command.outputs.command_state != 'unknown' }}
+      - name: Slash Command Dispatch for PRs
+        id: scd_prs
+        if: ${{ steps.determine_command.outputs.command_state != 'unknown' && steps.determine_command.outputs.is_issue_command != 'true' }}
         uses: peter-evans/slash-command-dispatch@v3
         with:
           token: ${{ secrets.GIT_PAT }}
+          reaction-token: ${{ secrets.GIT_PAT }}
           issue-type: "pull-request"
           reactions: true
           commands: ${{ env.commands_list }}
 
       - name: Edit comment with error message
         if: ${{ steps.determine_command.outputs.command_state == 'unknown' }}
-        uses: peter-evans/create-or-update-comment@v3
+        uses: peter-evans/create-or-update-comment@v4
         with:
           comment-id: ${{ github.event.comment.id }}
           body: |
-            > '/${{ steps.determine_command.outputs.command }}' is unknown command.
+            > '/${{ steps.determine_command.outputs.command }}' is an unknown command.
             > See '/help'
           reactions: eyes, confused

.gitignore

@@ -56,3 +56,6 @@ dist
 build
 build-tmp
 .npmrc
+
+# actions-hub
+.github/actions-hub

src/components/CellViews/DateTimeCell.js

@@ -1,12 +1,12 @@
 import { format, isValid } from "date-fns";
+export const dateTimeFormat = "MMM dd yyyy, HH:mm:ss";
 
 export const DateTimeCell = (column) => {
   const date = new Date(column.value);
-  const dateFormat = "MMM dd yyyy, HH:mm:ss";
 
   return column.value ? (
     <div style={{ whiteSpace: "nowrap" }}>
-      {isValid(date) ? format(date, dateFormat) : ""}
+      {isValid(date) ? format(date, dateTimeFormat) : ""}
     </div>
   ) : (
     ""

src/components/CellViews/ProjectCell.js

@@ -0,0 +1,45 @@
+import { getRoot } from "mobx-state-tree";
+import { Fragment } from "react";
+
+const ProjectLink = ({ project }) => {
+  const projectID = project.id;
+  const onClick = (e) => {
+    e.stopPropagation();
+
+  };
+
+  return (
+    <a href={`/projects/${projectID}/data`} onClick={onClick}>
+      {project.title}
+    </a>
+  );
+};
+
+export const ProjectCell = (cell) => {
+  const { original, value } = cell;
+  const root = getRoot(original);
+  const projectList = value
+    .map(projectRef => root.taskStore.associatedList.find(proj => proj.id === projectRef.project_id))
+    .filter(Boolean);
+
+  return (
+    <div
+      style={{
+        maxHeight: "100%",
+        overflow: "hidden",
+        fontSize: 12,
+        lineHeight: "16px",
+      }}
+    >
+      {projectList && (
+        projectList
+          .map((projectRef, index) => (
+            <Fragment key={projectRef.project_id}>
+              {index > 0 && ", "}
+              <ProjectLink project={projectRef} />
+            </Fragment>
+          ))
+      )}
+    </div>
+  );
+};

src/components/CellViews/StringCell.js

@@ -1,24 +1,31 @@
-const valueToString = (value) => {
+import { format, isValid } from "date-fns";
+import { dateTimeFormat } from "./DateTimeCell";
+
+export const valueToString = (value) => {
   if (typeof value === "string") return value;
+  /* if undefined or null we'll treat it as empty string */
+  if (value === undefined || value === null) return "";
+  if (value instanceof Date && isValid(value)) return format(value, dateTimeFormat);
 
   try {
+    /* JSON.stringify will handle JSON and non-strings, non-null, non-undefined */
     return JSON.stringify(value);
   } catch {
-    return value.toString();
+    return 'Error: Invalid JSON';
   }
 };
 
 export const StringCell = ({ value }) => {
+  const style = {
+    maxHeight: "100%",
+    overflow: "hidden",
+    fontSize: 12,
+    lineHeight: "16px",
+  };
+
   return (
-    <div
-      style={{
-        maxHeight: "100%",
-        overflow: "hidden",
-        fontSize: 12,
-        lineHeight: "16px",
-      }}
-    >
-      {value ? valueToString(value) : ""}
+    <div style={style}>
+      {valueToString(value)}
     </div>
   );
 };

src/components/CellViews/index.js

@@ -13,3 +13,5 @@ export { NumberCell as Number } from "./NumberCell";
 export { StringCell as String } from "./StringCell";
 export { StringCell as Text } from "./StringCell";
 export { VideoCell as Video } from "./VideoCell";
+export { ProjectCell as Project } from './ProjectCell';
+