Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

feat: Improved Keyboard and Mouse Control and selection capabilities #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Uhrendoktor
Copy link

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

I found bulk-selection to be very frustrating from the UI.

What is the new behavior?

(if this is a breaking or feature change)

Added additional keyboard and mouse shortcuts for a nicer selection experience.
This allows for the user to better use some of the bulk-editing experimental features. It's also easier to select a specific list of tasks to label.
Shortcut were only added to the list view (DataView and OldDataView)

shift+click bulk select
ctrl+click bulk deselect
shift+up select previous
shift+down select next
ctrl+up deselect previous
ctrl+down deselect next
shift+a select all
space toggle

remapped:
shift+up -> up focus previous
shift+up -> up focus next
shift+left -> enter label selected
shift+right -> escape stop labeling

What is the current behavior?

(if this is a breaking or feature change)

currently only the four remapped commands are implemented. besides toggling all tasks from the UI, there is no possibility to to any sort of bulk-selection.

What libraries were added/updated?

(list all with version changes)

"react-hotkeys-hook": "^2.4.0" -> "^4.0.0"
this version is needed due to its support for isHotkeyPressed

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

toggling each task by hand / using a filter to only select the desired tasks.

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

frontend:
Task-Selection (DataView, DataViewOld, DataStore, Table, TableOld, ...)
keymappings

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants