This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
feat: Improved Keyboard and Mouse Control and selection capabilities #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
I found bulk-selection to be very frustrating from the UI.
What is the new behavior?
(if this is a breaking or feature change)
Added additional keyboard and mouse shortcuts for a nicer selection experience.
This allows for the user to better use some of the bulk-editing experimental features. It's also easier to select a specific list of tasks to label.
Shortcut were only added to the list view (DataView and OldDataView)
shift+click
bulk selectctrl+click
bulk deselectshift+up
select previousshift+down
select nextctrl+up
deselect previousctrl+down
deselect nextshift+a
select allspace
toggleremapped:
shift+up
->up
focus previousshift+up
->up
focus nextshift+left
->enter
label selectedshift+right
->escape
stop labelingWhat is the current behavior?
(if this is a breaking or feature change)
currently only the four remapped commands are implemented. besides toggling all tasks from the UI, there is no possibility to to any sort of bulk-selection.
What libraries were added/updated?
(list all with version changes)
"react-hotkeys-hook": "^2.4.0" -> "^4.0.0"
this version is needed due to its support for
isHotkeyPressed
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
toggling each task by hand / using a filter to only select the desired tasks.
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
frontend:
Task-Selection (DataView, DataViewOld, DataStore, Table, TableOld, ...)
keymappings