Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: DIA-666: [FE] Semantic search polish #266

Merged
merged 21 commits into from
Nov 29, 2023

Conversation

yyassi-heartex
Copy link
Contributor

Improved semantic search behaviour by:

  1. binding upper limit we retrieve from tasks end point to threshold max
  2. update threshold on Enter when user is focused min/max fields in semantic search
  3. clear threshold if semantic search list is empty

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

(if it's not clear from description)

What feature flags were used to cover this change?

What alternative approaches were there?

This change affects (describe how if yes)

  • Performance
  • Security
  • UX - improved semantic search behavior

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

Which logical domain(s) does this change affect?

Semantic search, find similar

@yyassi-heartex yyassi-heartex merged commit dc7e27b into master Nov 29, 2023
5 checks passed
@yyassi-heartex yyassi-heartex deleted the fb-dia-666/semantic-search-polish branch November 29, 2023 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants