Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

refactor: OPTIC-429: Remove unused FF ff_front_dev_1470_dm_pagination_010422_short #305

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Feb 14, 2024

Important Note

To read this PR, please go through it commit by commit.
Due to the renaming of files that are identical to old file names, GitHub will show them as internal file modifications. However, if you view it commit by commit, you will discern that it's merely file renaming.
This refer to files in src/components/MainView/GridView/ folder

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

we currently have alot of duplicate code in DM related to pagination on Table/TableOld. no one uses the FF ff_front_dev_1470_dm_pagination_010422_short
Please note, we are maintaining the old behavior.

What does this fix?

Clean code

What is the new behavior?

No changes

What is the current behavior?

No changes

What libraries were added/updated?

No changes

Does this change affect performance?

No changes

Does this change affect security?

No changes

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@yyassi-heartex yyassi-heartex merged commit 49e1df7 into master Feb 15, 2024
8 checks passed
@yyassi-heartex yyassi-heartex deleted the fb-optic-429/remove-unused-ff branch February 15, 2024 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants