Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

feat: LEAP-572: Implement interface indicator for expired plans #308

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Feb 27, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

Tooltips or prompts should be implemented to provide explanations when users hover over or attempt to click these greyed-out buttons.

What is the new behavior?

Users will not be able to import additional data or create new projects, or label any data, when user tries to click on this buttons, it's showing a tooltip explaining to the user why it's not possible

Screenshot 2024-02-27 at 12 04 24

What feature flags were used to cover this change?

fflag_feat_front_leap_482_self_serve_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, just one minor replacement

@juliosgarbi juliosgarbi changed the base branch from fb-leap-482 to fb-leap-598 February 28, 2024 19:08
src/components/DataManager/Toolbar/instruments.js Outdated Show resolved Hide resolved
@juliosgarbi juliosgarbi dismissed hlomzik’s stale review February 29, 2024 15:15

It's already fixed as requested

@juliosgarbi juliosgarbi merged commit 46f0549 into fb-leap-598 Feb 29, 2024
1 check passed
@juliosgarbi juliosgarbi deleted the fb-leap-572 branch February 29, 2024 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants