This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LSDV-4600: Lead time for TextArea #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmartel
reviewed
Feb 24, 2023
bmartel
approved these changes
Feb 27, 2023
hlomzik
reviewed
Feb 27, 2023
hlomzik
suggested changes
Mar 23, 2023
hlomzik
suggested changes
Apr 18, 2023
It stores lead_time in the meta field of the main region instead of storing it in shared TextArea tag or its ephemeral TextAreaRegions.
hlomzik
approved these changes
May 2, 2023
nicholasrq
approved these changes
May 3, 2023
src/mixins/LeadTime.js
Outdated
| })) | ||
| .actions(self => ({ | ||
| internalCountTime(callTime) { | ||
| const now = +Date.now(); |
There was a problem hiding this comment.
Date.now() returns a number, you don't need to convert it to number
There was a problem hiding this comment.
Suggested change
| const now = +Date.now(); | |
| const now = Date.now(); |
- TypeScript! - no debounce, it's detected during calculations - two different approaches on how to count trailing events - schema with explanations - simpler usage
lead_time was not added up because of typo
Information in tags can be easily destroyed, the only source of truth is results/regions, so store data there.
Remove useless metaValue — all data in results and this meta were overrided by meta from result Add check for flag enabled
Gondragos
approved these changes
Jul 27, 2023
|
/git merge master
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 68.15% 68.16% +0.01%
==========================================
Files 439 441 +2
Lines 28086 28144 +58
Branches 7435 7455 +20
==========================================
+ Hits 19141 19185 +44
- Misses 7729 7740 +11
- Partials 1216 1219 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
Describe the reason for change
Annotation results now have a "lead_time"value in export data for textareas. The value reflects how much time the annotator spent typing values in this TextArea. Lead Time is calculated with minimal interaction time 0.5s and with debounce of the same 0.5s, for example:
What does this fix?
This solves a time tracking problem so that typing time of annotators can be calculated.
What libraries were added/updated?
N/A
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
N/A
What feature flags were used to cover this change?
fflag_fix_front_lsdv_4600_lead_time_27072023_shortDoes this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
Which logical domain(s) does this change affect?
Textarea, Lead Time