This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 316
fix: LSDV-5256: Stop automatically scrolling if current Paragraph is not on the screen #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
+ Coverage 67.19% 67.26% +0.07%
==========================================
Files 439 439
Lines 27972 28035 +63
Branches 7394 7420 +26
==========================================
+ Hits 18795 18859 +64
+ Misses 7924 7922 -2
- Partials 1253 1254 +1
☔ View full report in Codecov by Sentry. |
bmartel
suggested changes
Jul 17, 2023
bmartel
approved these changes
Jul 18, 2023
bmartel
reviewed
Jul 20, 2023
bmartel
approved these changes
Jul 21, 2023
yyassi-heartex
approved these changes
Jul 21, 2023
bmartel
reviewed
Jul 24, 2023
bmartel
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
What is the new behavior?
If user scrolls the container and the current playing Paragraph is outside the screen the automatically scroll will stop work and it will start working back if user returns the focus to the current playing Paragraph
What is the current behavior?
If the automatically scroll is turned on, the Paragraphs will scroll to the current paragraph every time its change, doesn't matter if the current Paragraph is in focus or not
What libraries were added/updated?
no
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
NA
What feature flags were used to cover this change?
fflag_feat_front_lsdv_e_278_continuous_scrolling_of_paragraph_segments_with_audio
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)