Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-5256: Stop automatically scrolling if current Paragraph is not on the screen #1502

Merged
merged 21 commits into from
Jul 27, 2023

Conversation

juliosgarbi
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

What is the new behavior?

If user scrolls the container and the current playing Paragraph is outside the screen the automatically scroll will stop work and it will start working back if user returns the focus to the current playing Paragraph

What is the current behavior?

If the automatically scroll is turned on, the Paragraphs will scroll to the current paragraph every time its change, doesn't matter if the current Paragraph is in focus or not

What libraries were added/updated?

no

Does this change affect performance?

no

Does this change affect security?

no

What alternative approaches were there?

NA

What feature flags were used to cover this change?

fflag_feat_front_lsdv_e_278_continuous_scrolling_of_paragraph_segments_with_audio

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Patch coverage: 84.14% and project coverage change: +0.07% 🎉

Comparison is base (75f403d) 67.19% compared to head (d9b4888) 67.26%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
+ Coverage   67.19%   67.26%   +0.07%     
==========================================
  Files         439      439              
  Lines       27972    28035      +63     
  Branches     7394     7420      +26     
==========================================
+ Hits        18795    18859      +64     
+ Misses       7924     7922       -2     
- Partials     1253     1254       +1     
Files Changed Coverage Δ
src/tags/object/Paragraphs/HtxParagraphs.js 78.41% <40.90%> (-1.96%) ⬇️
src/tags/object/Paragraphs/AuthorFilter.js 95.23% <100.00%> (+0.23%) ⬆️
src/tags/object/Paragraphs/Phrases.js 100.00% <100.00%> (ø)
src/tags/object/Paragraphs/model.js 82.10% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/tags/object/Paragraphs/HtxParagraphs.js Outdated Show resolved Hide resolved
src/tags/object/Paragraphs/HtxParagraphs.js Outdated Show resolved Hide resolved
@juliosgarbi juliosgarbi requested a review from bmartel July 17, 2023 22:02
@juliosgarbi juliosgarbi merged commit 188fb81 into master Jul 27, 2023
15 checks passed
@juliosgarbi juliosgarbi deleted the fb-lsdv-5256 branch July 27, 2023 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants