Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-5460: Paragraph is sync with audio and isn't automatically pausing anymore #1519

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Jul 31, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

Paragraph wasn't sync with audio without the contextual scrolling FF turned on, also the audio was auto pausing after change the paragraph that is being played

What does this fix?

Paragraph and audio is sync and paragraph doesn't pause automatically when active paragraph changes anymore

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@juliosgarbi juliosgarbi changed the title fix: LSDV-5460: Paragraph is sync with audio and isn't automatically … fix: LSDV-5460: Paragraph is sync with audio and isn't automatically pausing anymore Jul 31, 2023
@github-actions github-actions bot added the fix label Jul 31, 2023
@juliosgarbi juliosgarbi merged commit 096576f into master Aug 1, 2023
16 checks passed
@juliosgarbi juliosgarbi deleted the fb-lsdv-5460 branch August 1, 2023 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants