This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LSDV-5526: Fix duplication of classifications in LLM scenario #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
hlomzik
reviewed
Aug 29, 2023
hlomzik
reviewed
Aug 29, 2023
hlomzik
reviewed
Aug 29, 2023
| area.store.loadSuggestions(new Promise((resolve) => setTimeout(() => { | ||
| resolve(suggestions); | ||
| }, 1000)), x => x); | ||
| }, 1000); |
There was a problem hiding this comment.
why so long? can we reduce it to make it go faster?
There was a problem hiding this comment.
We surely can, but I don't know if it catch the problem when it appears.
hlomzik
approved these changes
Aug 29, 2023
yyassi-heartex
approved these changes
Aug 31, 2023
# Conflicts: # tests/functional/package.json # tests/functional/yarn.lock
# Conflicts: # tests/functional/yarn.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix some issues in existed LLM scenario such as:
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
What does this fix?
It fixes areas duplication and stop from making any changes in region and suggestion lists if we get null instead of new suggestion list.
What libraries were added/updated?
N/A
Does this change affect performance?
Nope
Does this change affect security?
Nope
What alternative approaches were there?
The alternative approach could be provided in the context of another tasks when we get understanding of what it should be.
What feature flags were used to cover this change?
fflag_feat_all_lsdv_e_294_llm_annotations_180723_longDoes this PR introduce a breaking change?
(check only one)
Enabling
flag_feat_all_lsdv_e_294_llm_annotations_180723_longcould break the previous scenarios used smart tools for Image Segmentation.What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Auto Annotating,TextArea