Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: OPTIC-109: Blank draft should not be created when an annotation is submitted #1562

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Sep 18, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

To help keep more control with the annotator's workflow we are going to be offering more aggressive draft saving, and notification of this. However it was identified that this would have introduced a regression with regards to creating a blank draft in doing so, and thus this fix is required to allow this functionality to be enabled in full.

What feature flags were used to cover this change?

  • fflag_feat_optic_2_ensure_draft_saved_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

LabelStream, QuickView

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage is 11.11% of modified lines.

Files Changed Coverage
src/components/BottomBar/Controls.js 0.00%
src/stores/Annotation/Annotation.js 25.00%
src/stores/AppStore.js 100.00%

📢 Thoughts on this report? Let us know!.

@bmartel bmartel merged commit 688ba57 into master Sep 22, 2023
14 checks passed
@bmartel bmartel deleted the fb-optic-109 branch September 22, 2023 15:06
wesleylima pushed a commit that referenced this pull request Sep 25, 2023
…is submitted (#1562)

* fix: OPTIC-109: Blank draft should not be created when an annotation is submitted

* dont save a draft after the submission has started

* ensure we arent double submitting drafts

* dont need statusCallback

* update cypress
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants