This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 316
fix: LEAP-439: Add maskData exporting into new MIG serialization approach #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1659 +/- ##
==========================================
+ Coverage 64.56% 68.32% +3.75%
==========================================
Files 443 443
Lines 28693 28704 +11
Branches 7519 7633 +114
==========================================
+ Hits 18527 19613 +1086
+ Misses 10166 7840 -2326
- Partials 0 1251 +1251 ☔ View full report in Codecov by Sentry. |
yyassi-heartex
approved these changes
Jan 8, 2024
hlomzik
approved these changes
Jan 8, 2024
Nice description! Could you please also add a short technical explanation to it as well? I see that you create a cached image that is used later. |
…k-export # Conflicts: # tests/functional/package.json # tests/functional/yarn.lock
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
…oach (HumanSignal#1659) * fix: LEAP-439: Add maskData exporting into new MIG serialization approach * Update version of @heartexlabs/ls-test dependency * Add serialization/deserialization test for Magic Wand tool * fix import path * Configure timeouts * Update @heartexlabs/ls-test dependency version * Update @heartexlabs/ls-test dependency * Update "@heartexlabs/ls-test" dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the new brush mask exporting approach to handle masks created by Magic Wand tool.
PR fulfills these requirements
Describe the reason for change
The introduction of the feature flag
fflag_feat_front_lsdv_4583_multi_image_segmentation_short
has resulted in a new method for serializing brush masks into RLE (Run-Length Encoding). As a result, themaskDataUrl
serialization was lost. Consequently, we are no longer able to submit results generated by the Magic Wand tool.What feature flags were used to cover this change?
This is an universal solution. No ff is needed.
What alternative approaches were there?
N/A
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
MIG
,Brush
,MagicWand
,Serialization