Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-439: Add maskData exporting into new MIG serialization approach #1659

Merged
merged 9 commits into from
Jan 9, 2024

Conversation

Gondragos
Copy link
Contributor

Enhance the new brush mask exporting approach to handle masks created by Magic Wand tool.

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

The introduction of the feature flag fflag_feat_front_lsdv_4583_multi_image_segmentation_short has resulted in a new method for serializing brush masks into RLE (Run-Length Encoding). As a result, the maskDataUrl serialization was lost. Consequently, we are no longer able to submit results generated by the Magic Wand tool.

What feature flags were used to cover this change?

This is an universal solution. No ff is needed.

What alternative approaches were there?

N/A

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

Which logical domain(s) does this change affect?

MIG, Brush, MagicWand, Serialization

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1e4416) 64.56% compared to head (2190d62) 68.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
+ Coverage   64.56%   68.32%   +3.75%     
==========================================
  Files         443      443              
  Lines       28693    28704      +11     
  Branches     7519     7633     +114     
==========================================
+ Hits        18527    19613    +1086     
+ Misses      10166     7840    -2326     
- Partials        0     1251    +1251     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlomzik
Copy link
Collaborator

hlomzik commented Jan 8, 2024

Nice description! Could you please also add a short technical explanation to it as well? I see that you create a cached image that is used later.

@Gondragos Gondragos enabled auto-merge (squash) January 9, 2024 20:13
@Gondragos Gondragos merged commit a3e4f43 into master Jan 9, 2024
11 of 13 checks passed
@Gondragos Gondragos deleted the fb-leap-439/new-mask-export branch January 9, 2024 21:10
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
…oach (HumanSignal#1659)

* fix: LEAP-439: Add maskData exporting into new MIG serialization approach

* Update version of @heartexlabs/ls-test dependency

* Add serialization/deserialization test for Magic Wand tool

* fix import path

* Configure timeouts

* Update @heartexlabs/ls-test dependency version

* Update @heartexlabs/ls-test dependency

* Update "@heartexlabs/ls-test" dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants