This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-515: Fix CommentForm for old UI #1661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotationStore was not passed to Comments panel there
PR fulfills these requirements
Describe the reason for change
This was breaking the app completely when old interface is enabled (2 FFs are OFF) and comments interface is enabled as well.
What feature flags were used to cover this change?
This bug happens only if those 2 flags are disabled:
ff_front_1170_outliner_030222_short
fflag_feat_front_dev_3873_labeling_ui_improvements_short
What alternative approaches were there?
Inject AppStore to Comments.tsx as we usually do, but typescript can't understand this injection, so let's just pass it through.
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?