Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-515: Fix CommentForm for old UI #1661

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Jan 9, 2024

annotationStore was not passed to Comments panel there

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

This was breaking the app completely when old interface is enabled (2 FFs are OFF) and comments interface is enabled as well.

What feature flags were used to cover this change?

This bug happens only if those 2 flags are disabled:

  • ff_front_1170_outliner_030222_short
  • fflag_feat_front_dev_3873_labeling_ui_improvements_short

What alternative approaches were there?

Inject AppStore to Comments.tsx as we usually do, but typescript can't understand this injection, so let's just pass it through.

This change affects (describe how if yes)

  • Performance
  • Security
  • UX — original change was improving Comments UX and this one fixes app crash

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

annotationStore was not passed to Comments panel there
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (28c0e12) 68.31% compared to head (5cb5557) 64.56%.
Report is 3 commits behind head on master.

Files Patch % Lines
src/components/App/Grid.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
- Coverage   68.31%   64.56%   -3.75%     
==========================================
  Files         443      443              
  Lines       28699    28700       +1     
  Branches     7633     7520     -113     
==========================================
- Hits        19606    18531    -1075     
- Misses       7841    10169    +2328     
+ Partials     1252        0    -1252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlomzik hlomzik enabled auto-merge (squash) January 9, 2024 20:12
@hlomzik hlomzik merged commit d4182be into master Jan 9, 2024
15 of 16 checks passed
@hlomzik hlomzik deleted the fb-leap-515/comments-old-ui branch January 9, 2024 20:22
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
annotationStore was not passed to Comments panel there
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants