This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-240: Prevent creating region on clicking outside selected one #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyassi-heartex
approved these changes
Jan 18, 2024
Updated the handleDeferredMouseDown method to accept a boolean argument that represents whether the mouse was clicked or not. This modification prevents unwanted deselection of regions and labels by ensuring that this event occurs only when the mouse was clicked and deselection is intentional.
|
/git merge master
|
|
/git merge master
|
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
…ne (HumanSignal#1667) * fix: LEAP-240: Prevent creating region on clicking outside selected one * Add tests for clicking outside selected region * Ensure that unselecting labels and regions was initiated only by click. Updated the handleDeferredMouseDown method to accept a boolean argument that represents whether the mouse was clicked or not. This modification prevents unwanted deselection of regions and labels by ensuring that this event occurs only when the mouse was clicked and deselection is intentional. * Add tests for checking labels behaviour --------- Co-authored-by: Gondragos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a functionality under the feature flag that allows us unselect selected region by clicking outside.
Well... It doesn't work with separated tools like
<Rectangle>tag. So we are going to fix it.PR fulfills these requirements
What feature flags were used to cover this change?
ff_front_dev_1442_unselect_shape_on_click_outside_080622_shortThis change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
ImageView,Image Segmentation,Image Tools