Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

docs: LEAP-615: Mention spaces saving for Text tag #1682

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Jan 27, 2024

Text tag is displayed as html, so all spaces are smashed by browser, and they also go like this to result. To avoid this users can add custom style in config, described in docs. But it only says that this affects displaying, not saving the result. Adding this note as well.

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

HumanSignal/label-studio#5338

Text tag is displayed as html, so all spaces are smashed by browser, and they also go like this to result. To avoid this users can add custom style in config, described in docs. But it only says that this affects displaying, not saving the result. Adding this note as well.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9c9552) 68.70% compared to head (af738d8) 68.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1682   +/-   ##
=======================================
  Coverage   68.70%   68.70%           
=======================================
  Files         443      443           
  Lines       28734    28734           
  Branches     7641     7641           
=======================================
  Hits        19742    19742           
  Misses       7748     7748           
  Partials     1244     1244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Feb 6, 2024

/merge master

@hlomzik
Copy link
Collaborator Author

hlomzik commented Feb 15, 2024

/git merge master

Workflow run
Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-615/spaces-in-text-results-docs (bcdaa78)

@hlomzik hlomzik enabled auto-merge (squash) February 15, 2024 09:32
@hlomzik hlomzik merged commit 48dee3c into master Feb 15, 2024
11 of 13 checks passed
@hlomzik hlomzik deleted the fb-leap-615/spaces-in-text-results-docs branch February 15, 2024 09:50
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
* docs: LEAP-615: Mention spaces saving for Text tag

Text tag is displayed as html, so all spaces are smashed by browser, and they also go like this to result. To avoid this users can add custom style in config, described in docs. But it only says that this affects displaying, not saving the result. Adding this note as well.

* Very small edit

---------

Co-authored-by: Caitlin Wheeless <[email protected]>
Co-authored-by: hlomzik <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants