This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are external places that can call
destroy()
unconditionally, so having it uninitialized is dangerous and leads to app crash.Note: 4 e2e tests are disabled waiting for #1708
PR fulfills these requirements
Describe the reason for change
App was crashing in Config Preview (editor) when you use config with
Image
tag and change itsvalue
resulting in errorf.current.destroy is not a function
What feature flags were used to cover this change?
That only happens with
fflag_feat_front_lsdv_4583_6_images_preloading_short
ONAnd despite the change was introduced in #1640 it happens even with
fflag_fix_front_leap_443_select_annotation_once
OFFWhat alternative approaches were there?
Check what's going on with image preloading that forces Preview to destroy LSF in some different way. Will do this later.
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?