This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
ci: LEAP-753: e2e image problems no externals #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calculate natural image size to calculate a real zoom on init (~1.05) - Remove unnecessary waits, especially the one for 10(!) seconds - Enable DEV-3377 FF to fix region shift on zoom - Enable DEV-3793 FF to use relative coords for proper calculations - Fix the way FF applied — they should be set before the `I.amOnPage()` - Precision is increased to 2 (lower precisions result in rounding errors) - Added comments to understand the flow of the test and exact calculations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.