Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: hotkeys not unbind #1720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

benyueer
Copy link

@benyueer benyueer commented Apr 1, 2024

Fixed the issue of shortcut keys not being logged out

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

#1719

@github-actions github-actions bot added the fix label Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant