Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LSDV-5222: custom weights reset following labeling interface changes #4611

Merged
merged 6 commits into from
Aug 14, 2023
Merged

fix: LSDV-5222: custom weights reset following labeling interface changes #4611

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86ad772
feat: LSDV-5222: Add ids to labels to allow for persistence of custom…
dredivaris Aug 3, 2023
45c4cfa
Revert changes related to using a label id and add fix for resetting …
dredivaris Aug 4, 2023
bb2114c
Update get_label so it doesn't have to be called twice in comprehension
dredivaris Aug 7, 2023
15a1087
Update so overall section is also covered when it is set to 0
dredivaris Aug 8, 2023
831dd96
Merge branch 'develop' into fb-lsdv-5222
dredivaris Aug 10, 2023
0937b17
Fix fetching of overall weight as there are subtle issues with the de…
dredivaris Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions label_studio/projects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,14 +589,29 @@ def get_updated_weights(self):
outputs = self.get_parsed_config(autosave_cache=False)
control_weights = {}
exclude_control_types = ('Filter',)

def get_label(label):
label_value = self.control_weights.get(control_name, {}).get('labels', {}).get(label)
return label_value if label_value is not None else 1.0

def get_overall(name):
weights = self.control_weights.get(name, None)
if not weights:
return 1.0
else:
weight = weights.get('overall', None)
return weight if weight is not None else 1.0


for control_name in outputs:
control_type = outputs[control_name]['type']
if control_type in exclude_control_types:
continue

control_weights[control_name] = {
'overall': self.control_weights.get(control_name, {}).get('overall') or 1.0,
'overall': get_overall(control_name),
'type': control_type,
'labels': {label: self.control_weights.get(control_name, {}).get('labels', {}).get(label) or 1.0 for label in outputs[control_name].get('labels', [])},
'labels': {label: get_label(label) for label in outputs[control_name].get('labels', [])},
}
return control_weights

Expand Down
Loading