Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1097: Show Review buttons in Quick View #5930

Merged
merged 20 commits into from
Jun 10, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented May 29, 2024

If that's the task of another person we will show Accept/Reject. Part of "Reviewer Flow" experiment, hidden behind FF.

  • Check if user is of Manager role
  • Check if we are in Quick View

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

(if it's not clear from main description — otherwise remove this section)

What feature flags were used to cover this change?

fflag_feat_all_leap_1081_reviewer_flow_updates

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

If that's the task of another person we will show Accept/Reject.
Works only with FF on.
Copy link

netlify bot commented May 29, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9bf6354
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66670724ad06dd00087c8200

@github-actions github-actions bot added the feat label May 29, 2024
Copy link

netlify bot commented May 29, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 9bf6354
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/666707241b86a20008c4be25

@hlomzik
Copy link
Collaborator Author

hlomzik commented Jun 7, 2024

/git merge

Workflow run
Successfully merged: 7 files changed, 109 insertions(+), 150 deletions(-)

@hlomzik hlomzik enabled auto-merge (squash) June 7, 2024 14:01
@hlomzik
Copy link
Collaborator Author

hlomzik commented Jun 10, 2024

/git merge

Workflow run
Successfully merged: 34 files changed, 1598 insertions(+), 78 deletions(-)

@hlomzik hlomzik merged commit d366bab into develop Jun 10, 2024
30 checks passed
@hlomzik hlomzik deleted the fb-leap-1097/review-in-quick-view branch June 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants