Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1650: pkg_resources deprecation problems for 3.12,3.13 #6638

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jombooth
Copy link
Contributor

@jombooth jombooth commented Nov 12, 2024

pkg_resources was deprecated in python 3.12; replace usages with importlib and address imported packages that use pkg_resources as well. boxing has been replaced with the very similar pyboxen.

@github-actions github-actions bot added the fix label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 2d18e3e
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67344c1547ed19000886dead

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 2d18e3e
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67344c15f9a12d0008718e1b

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.70%. Comparing base (e6e68f0) to head (2d18e3e).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/utils/common.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6638      +/-   ##
===========================================
+ Coverage    76.67%   76.70%   +0.03%     
===========================================
  Files          169      169              
  Lines        13844    13846       +2     
===========================================
+ Hits         10615    10621       +6     
+ Misses        3229     3225       -4     
Flag Coverage Δ
pytests 76.70% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jombooth jombooth merged commit 92c85c5 into develop Nov 13, 2024
42 of 43 checks passed
@jombooth jombooth deleted the fb-LEAP-1650 branch November 13, 2024 19:22
@farioas
Copy link
Member

farioas commented Nov 13, 2024

Best change, been waiting for it for two years
LGTM 🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants