Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French translations #991

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

French translations #991

wants to merge 3 commits into from

Conversation

mr-aboutin
Copy link
Contributor

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

Orace
Orace reviewed Jun 9, 2021
View reviewed changes
src/Humanizer.Tests.Shared/TimeSpanHumanizeTests.cs
[Theory]
[InlineData(34390862500, "1 Y, 1 M, 2 d, 1 h, 1 m, 2 s, 500 ms", TimeUnit.Millisecond)]
[InlineData(604800000, "1 W", TimeUnit.Millisecond)]
public void TimeSpanWithAllUnitsAbb(long ms, string expected, TimeUnit minUnit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minUnit argument is not used here.

@SimonCropp
Copy link
Collaborator

@mr-aboutin can you add some docs on how abbreviate work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orace Orace Orace left review comments

Assignees
No one assigned
Labels
localisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-aboutin @SimonCropp @Orace @clairernovotny