Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.15] Do not use recalc lock for run-recalc #2127

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[0.15] Do not use recalc lock for run-recalc #2127

merged 1 commit into from
Oct 24, 2024

Conversation

rh-appservices-perf
Copy link
Collaborator

Backport: #2084

Fixes Issue

Fixes #1975

Changes proposed

  • Do not use shared lock during labelValues computation
  • Move shared lock usage into ServiceMediator if really required
  • Manage concurrent runs transformation similarly to what we are doing for test datasets recalculation
  • Fix the test datasets recalculation modal (show correct data)

image

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr
Don't use lock for labelValues computation
21ac0a2 
As part of this the following changes have been added:
- Manage concurrent runs transformation
- Fix test recalculation modal

Signed-off-by: Andrea Lamparelli <[email protected]>
@lampajr lampajr merged commit a19451e into 0.15 Oct 24, 2024
3 checks passed
@lampajr lampajr deleted the bp-0.15-1e267f7 branch October 24, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr approved these changes

@johnaohara johnaohara Awaiting requested review from johnaohara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rh-appservices-perf @lampajr