Save and make available additional reporting_org fields #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifying refactor ahead of database changes: * remove unneeded factory methods * fetch org metadata each run
Tests to check list of IATI organisations are added, updated and deleted from new DB table.
* Refactored some tests and test data to facilitate testing given that org data will now be drawn from the full org metadata, and not the limited org metadata on the datasets
* Add 'dataset' to names now there are also entries for organisations.
Previously, if the zipper was run standalone from the command line, it would crash at the end when updating prom metrics. This would only ever occur during local development, but this fixes it.
* toml package installed to allow programmatic access to version * Python upgraded because latest black doesn't run with 3.12.5
tillywoodfield
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main addition in this update is that the Bulk Data Service now:
(Organisations have been renamed reporting_orgs in recognition that it is always reporting_orgs we are dealing with in this data).
In addition, the version of the app is now stored in
pyproject.toml, and should be updated there every release, and the value it is updated to should be used in the standard release process. The version has been stored in pyproject so that it can be included in theUser-Agentheader.A new dependency (
toml) led to an upgrade ofblack, which in turn required upgradingPythonto 3.12.6