Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to XML file in breadcrumbs doesn't work - something to do with the new design system implementation? #862

Closed
stevieflow opened this issue Jan 20, 2025 · 4 comments
Closed

Link to XML file in breadcrumbs doesn't work - something to do with the new design system implementation? #862

stevieflow opened this issue Jan 20, 2025 · 4 comments
Assignees
@chrisarridge
Labels
bug Something isn't working

Comments

@stevieflow
Copy link

Going to a page about the validation of a file:

https://validator.iatistandard.org/report/dhsc-activities-ghr

In the breadcrumbs, the xml file is an active link, but leads to a 404:

Image

I don't think this was the case previously and/or if this was, it would have just linked to the page you were already on

To fix this, suggest that this breadcrumb element if not an active link

@tillywoodfield @robredpath cc/ @IsabelBirds
@stevieflow stevieflow added the bug Something isn't working label Jan 20, 2025
@stevieflow stevieflow mentioned this issue Jan 20, 2025
Open
@IsabelBirds
Copy link

I think this used to link directly to the XML file, not another validator site page

@chrisarridge chrisarridge self-assigned this Jan 22, 2025
chrisarridge added a commit that referenced this issue Jan 22, 2025
@chrisarridge
fix: report page XML links fixed to point to external page
a2ae7ba 
Fixes issue #862 where
links to XML files on the report page were built as an internal link
on the validator site.  Think this change in behaviour is due to
the removal of <StyledLink> which checked for external URLs first
and used :href instead of :to in those cases.  Changed this
<RouterLink> to set the link using :href as we know it's an external
link.
@chrisarridge chrisarridge mentioned this issue Jan 22, 2025
Merged
@chrisarridge
Copy link
Contributor

I have a hot fix for this (#868) that fixes this specific case. If there are any cases where the link points "...to the page you were already on" then that would be useful to know as it might mean my fix breaks something elsewhere.

@chrisarridge
Copy link
Contributor

Fix is now live.

@stevieflow
Copy link
Author

Thanks @chrisarridge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisarridge chrisarridge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevieflow @IsabelBirds @chrisarridge