Fix error where report page XML links are malformed #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #862 where links to XML files on the report page were built as an internal link on the validator site. Think this change in behaviour is due to the removal of <StyledLink> which checked for external URLs first and used :href instead of :to in those cases. Changed this <RouterLink> to set the link using :href as we know it's an external link.
simon-20
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a hot fix for issue #862 where links to XML files on the report page were built as an internal link on the validator site. Think this change in behaviour is due to the removal of
<StyledLink>which checked for external URLs first and used:hrefinstead of:toin those cases. Changed this<RouterLink>to set the link using:hrefas we know links to XML files will be external to the validator. This PR does not check the rest of the application for similar instances.