Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled the user to set 'enabled' value for feature flag #5940

Merged
merged 20 commits into from
Jan 28, 2025

Conversation

prajwal-jarali
Copy link
Contributor

PR details:-

  • Made enabled value optional instead of computed value
  • Added respective code in create and update feature to read enabled vale and send it to go-admin-sdk for provisioning of resource
  • Updated feature flag resource creation test to test for enabled field also

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from make build

==> Checking that code complies with gofmt requirements...
go vet .
go install

Output from Acceptance test

=== RUN   TestAccIbmIbmAppConfigFeatureBasic
--- PASS: TestAccIbmIbmAppConfigFeatureBasic (77.06s)
PASS
ok      [github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration](http://github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration)        78.452s (edited)

@hkantare
Copy link
Collaborator

Does it requires any doc changes

@prajwal-jarali
Copy link
Contributor Author

Does it requires any doc changes

I have added the required documentation changes 3856d99

@hkantare hkantare merged commit 31732cc into IBM-Cloud:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants