Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps SwiftyJSON dependency version to match the version Kitura uses #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nesty
Copy link

@nesty nesty commented Sep 26, 2017

Fixes swift build infinity loop when building projects with Kitura (requires version 17) and GRMustache.swift (required version 16.0).

Fixes `swift build` infinity loop when building projects with `Kitura` (requires version 17) and `GRMustache.swift` (required version 16.0).
@helenmasters
Copy link

helenmasters commented Feb 2, 2018

Hi @nesty - I've been looking at templating and noticed that this PR has been outstanding
for a long time, apologies :-(

Given that you would need to have signed the CLA (Contributor License Agreement) before we would have been able to merge your request I took the quicker route of creating a new PR #12 and merging that instead. Please do contribute to our other IBM-Swift repositories (which are not at IBM-Swift-Sunset) where the CLA signing is now an automated process. Once again my apologies that this issue has been on the queue for so long.

Hopefully this issue can now be closed as Kitura no longer depends on SwiftyJSON, but given that SwiftMetrics still does you would have had the same problem there so I have tested the fix and you can now use SwiftMetrics successfully alongside GRMustache.

Regards Helen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants