Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

add in search of 'N/A' #700

Merged
merged 1 commit into from
May 30, 2019
Merged

add in search of 'N/A' #700

merged 1 commit into from
May 30, 2019

Conversation

NickyDaB
Copy link
Contributor

Purpose

Address issues in #682

Approach

I believe that UFM restAPIs changed the output of a missing serial number in the most recent update. Previously we searched for NA now it displays as N/A. We now look for both forms in our code.

Future: We need to add in more tests to regression: #686

Origin

@thanh-lam opened #682

How to Test

This section will help the regression tester.

  1. Have a cable with a N/A serial number.
  2. run inventory on master, this cable will get put into the CSM database.
  3. checkout this branch
  4. Have a cable with a N/A serial number.
  5. run inventory on this branch, this cable will not get put into the CSM database. instead get placed into 'bad_records'

ToDo:

  • @pdlun92 run regression. If you have any other questions please ask.

Copy link
Contributor

@pdlun92 pdlun92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes regression and unit testing

@NickyDaB NickyDaB merged commit 81da548 into IBM:master May 30, 2019
@NickyDaB NickyDaB deleted the issue-628 branch June 7, 2019 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants