fixed the column visibility not being applied on reload

ICRAR · Jan 17, 2025 · a0428f4 · a0428f4
1 parent 70dbed5
commit a0428f4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 20 deletions.
diff --git a/src/ParameterTable.ts b/src/ParameterTable.ts
@@ -825,51 +825,52 @@ export class ColumnVisibilities {
         localStorage.setItem('ColumnVisibilities', JSON.stringify(columnVisibilitiesObjArray));
     }
 
-     loadFromLocalStorage = () : void => {
+    loadFromLocalStorage = () : void => {
         const columnVisibilitiesObjArray : any[] = JSON.parse(localStorage.getItem('ColumnVisibilities'))
         const that = ParameterTable.getActiveColumnVisibility()
         if(columnVisibilitiesObjArray === null){
             return
         }else{
             columnVisibilitiesObjArray.forEach(function(columnVisibility){
+
                 const columnVisActual:ColumnVisibilities = that.getModeByName(columnVisibility.name)
-                if(columnVisibility.keyAttribute){
+                if(columnVisibility.keyAttribute != null){
                     columnVisActual.setKeyAttribute(columnVisibility.keyAttribute)
                 }
-                if(columnVisibility.displayText){
+                if(columnVisibility.displayText != null){
                     columnVisActual.setDisplayText(columnVisibility.displayText)
                 }
-                if(columnVisibility.fieldId){
+                if(columnVisibility.fieldId != null){
                     columnVisActual.setFieldId(columnVisibility.fieldId)
                 }
-                if(columnVisibility.value){
+                if(columnVisibility.value != null){
                     columnVisActual.setValue(columnVisibility.value)
                 }
-                if(columnVisibility.readOnly){
+                if(columnVisibility.readOnly != null){
                     columnVisActual.setReadOnly(columnVisibility.readOnly)
                 }
-                if(columnVisibility.defaultValue){
+                if(columnVisibility.defaultValue != null){
                     columnVisActual.setDefaultValue(columnVisibility.defaultValue)
                 }
-                if(columnVisibility.description){
+                if(columnVisibility.description != null){
                     columnVisActual.setDescription(columnVisibility.description)
                 }
-                if(columnVisibility.type){
+                if(columnVisibility.type != null){
                     columnVisActual.setType(columnVisibility.type)
                 }
-                if(columnVisibility.parameterType){
+                if(columnVisibility.parameterType != null){
                     columnVisActual.setParameterType(columnVisibility.parameterType)
                 }
-                if(columnVisibility.usage){
+                if(columnVisibility.usage != null){
                     columnVisActual.setUsage(columnVisibility.usage)
                 }
-                if(columnVisibility.encoding){
+                if(columnVisibility.encoding != null){
                     columnVisActual.setEncoding(columnVisibility.encoding)
                 }
-                if(columnVisibility.flags){
+                if(columnVisibility.flags != null){
                     columnVisActual.setFlags(columnVisibility.flags)
                 }
-                if(columnVisibility.actions){
+                if(columnVisibility.actions != null){
                     columnVisActual.setActions(columnVisibility.actions)
                 }
             })

diff --git a/static/tables.css b/static/tables.css
@@ -61,10 +61,6 @@
     overflow: hidden;
 }
 
-td:first-child input {
-    font-weight: 700;
-}
-
 .parameterTableVisibilityContainer{
     position:absolute;
     right: 320px;

diff --git a/templates/node_parameter_table.html b/templates/node_parameter_table.html
@@ -428,7 +428,6 @@ <h5 class="bottomWindowHeader">Fields Table: </h5>
 
                                             <!-- ko if: ParameterTable.getActiveColumnVisibility().encoding() && eagle.selectedNode().isApplication() -->
                                                 <td class='columnCell column_Encoding'>
-
                                                     <!-- ko if: $data.usage() === Daliuge.FieldUsage.NoPort-->
                                                         <span class="faded">N/A</span>
                                                     <!-- /ko -->
@@ -439,7 +438,6 @@ <h5 class="bottomWindowHeader">Fields Table: </h5>
                                                             </select>
                                                         </div>
                                                     <!-- /ko -->
-
                                                 </td>
                                             <!-- /ko -->