-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAGLE-1295: Add support for "LocalDirectory"-type repositories #753
base: master
Are you sure you want to change the base?
Conversation
…ping for FileSystemHandle variables
…he various inputs based on the type of repository selected in the drop down.
…-type repos. Sorting of folders/files in the LocalDirectory-type repos.
…priate. Show for git repos, hide for LocalDirectory-type repos
…SystemDirectoryHandle can not be stored as a string, requires IndexedDB
Reviewer's Guide by SourceryThis PR adds support for "LocalDirectory"-type repositories, allowing users to load and save graphs directly from local directories without git. The implementation reuses existing UI components, adapts them for local directory operations, and adds new functionality to handle local filesystem operations using the File System Access API. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @james-strauss-uwa - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…e in the wrong place if a directory was specified incorrectly, resulting in the wrong file returned.
Allow users to add "LocalDirectory"-type repositories to EAGLE's repository list. User's can load and save graphs as normal.
We re-use the "add custom git repository" modal to add the LocalDirectory-type repository. I've just removed the word "git" from the modal title.
We re-use the "git commit" modal to save files. I've just removed the word "git" from the modal title. And I hide the "commit message" input on the modal if we are saving to a "LocalDirectory"-type repo.
The contents of the "LocalDirectory"-type repos are shown as expected. Only graphs, palettes, and READMEs are shown, other files are hidden. The ".git" directory is hidden. Files are sorted directories-first, then alphabetically.
I also made a change to the Typescript config JSON (tsconfig.json), adding two libraries: "DOM.Iterable" and "DOM.AsyncIterable". These are required to provide type definitions for the FileSystemHandle.entries() function.
Issues:
I'm planning on adding "LocalGit"-type next, which will rely on the eagleServer.py loading data from git repos.
Summary by Sourcery
Introduce support for 'LocalDirectory'-type repositories, enabling users to manage local directories similarly to Git repositories. Adjust the UI and repository handling logic to integrate this new repository type, and update TypeScript configuration to support necessary file system operations.
New Features:
Enhancements:
Build: