Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate button, cleanup parameters and logging (backport #25) #26

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 20, 2024

Major features in this PR:

  • Implement button emulation, see TODO: use dhdEmulateButton() #24
  • Add HW parameters for
    • interface_id, default = -1
    • emulate_button, default = false
    • fd_interface_name, default = fd_inertia
  • update ros2 control description

Minor changes:

  • cleanup logging using uniquely defined logger
  • add debug logs in fd_inertia_broadcaster and fd_clutch_broadcaster

This is an automatic backport of pull request #25 done by [Mergify](https://mergify.com).

* add debug logs

* add parameters for emulate_button and interface_id

* make fd_inertia a parameter also

* emulate button

* update description file

* linting

* cleanup logging

(cherry picked from commit 432de6d)
@tpoignonec tpoignonec merged commit 295d123 into humble Aug 20, 2024
3 checks passed
@tpoignonec tpoignonec deleted the mergify/bp/humble/pr-25 branch August 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant