-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jupyter Notebook for fixed bed 0D TSA #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect there is another step required to add this notebook to the docs index, but I do not know what that is. I think there is documentation somewhere- either in the readme or a wiki page.
Updated to include the notebook to the docs index |
This depends on IDAES/idaes-pse#1232 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few minor comments, but someone with some more time should do a second check as well.
...es/notebooks/docs/flowsheets/temperature_swing_adsorption/temperature_swing_adsorption.ipynb
Outdated
Show resolved
Hide resolved
...es/notebooks/docs/flowsheets/temperature_swing_adsorption/temperature_swing_adsorption.ipynb
Outdated
Show resolved
Hide resolved
...es/notebooks/docs/flowsheets/temperature_swing_adsorption/temperature_swing_adsorption.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple very minor comments. After fixing the main notebook file, re-run idaesx pre
to update the other notebook files.
...es/notebooks/docs/flowsheets/temperature_swing_adsorption/temperature_swing_adsorption.ipynb
Show resolved
Hide resolved
...es/notebooks/docs/flowsheets/temperature_swing_adsorption/temperature_swing_adsorption.ipynb
Outdated
Show resolved
Hide resolved
...es/notebooks/docs/flowsheets/temperature_swing_adsorption/temperature_swing_adsorption.ipynb
Outdated
Show resolved
Hide resolved
@Daison2102, will this make the Nov release? The plan is to cut the RC on the 27th. |
Yes @ksbeattie , all comments from @bpaul4 and @andrewlee94 have been addressed |
@Daison2102 Note that example notebooks now need to have an author and maintainer recorded in the header (so we know who to contact if things break). |
@andrewlee94 added |
Title
Fixes #{Issue}
Example of the use of the IDAES fixed bed 0D TSA model
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--66.org.readthedocs.build/en/66/