Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter Notebook for fixed bed 0D TSA #66

Merged
merged 13 commits into from
Nov 13, 2023
Merged

Conversation

Daison2102
Copy link
Contributor

@Daison2102 Daison2102 commented Jul 27, 2023

Title

Fixes #{Issue}

Example of the use of the IDAES fixed bed 0D TSA model


Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--66.org.readthedocs.build/en/66/

@Daison2102 Daison2102 self-assigned this Jul 27, 2023
@Daison2102 Daison2102 added the Priority:Normal Normal Priority Issue or PR label Jul 27, 2023
Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there is another step required to add this notebook to the docs index, but I do not know what that is. I think there is documentation somewhere- either in the readme or a wiki page.

@Daison2102
Copy link
Contributor Author

I suspect there is another step required to add this notebook to the docs index, but I do not know what that is. I think there is documentation somewhere- either in the readme or a wiki page.

Updated to include the notebook to the docs index

@Daison2102 Daison2102 requested a review from bpaul4 July 28, 2023 19:23
@ksbeattie
Copy link
Member

This depends on IDAES/idaes-pse#1232

Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few minor comments, but someone with some more time should do a second check as well.

Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple very minor comments. After fixing the main notebook file, re-run idaesx pre to update the other notebook files.

@ksbeattie
Copy link
Member

@Daison2102, will this make the Nov release? The plan is to cut the RC on the 27th.

@Daison2102
Copy link
Contributor Author

Daison2102 commented Nov 13, 2023

@Daison2102, will this make the Nov release? The plan is to cut the RC on the 27th.

Yes @ksbeattie , all comments from @bpaul4 and @andrewlee94 have been addressed

@andrewlee94
Copy link
Member

andrewlee94 commented Nov 13, 2023

@Daison2102 Note that example notebooks now need to have an author and maintainer recorded in the header (so we know who to contact if things break).

@Daison2102
Copy link
Contributor Author

@Daison2102 Note that example notebooks now need to have an author and maintainer recorded in the header (so we know who to contact if things break).

@andrewlee94 added

@andrewlee94 andrewlee94 enabled auto-merge (squash) November 13, 2023 21:44
@andrewlee94 andrewlee94 merged commit 3a4246a into main Nov 13, 2023
6 checks passed
@andrewlee94 andrewlee94 deleted the Fixedbed_TSA_0D_Example branch November 13, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants