Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating example to remove variable fixed outside bound #81

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Updating example to remove variable fixed outside bound #81

merged 1 commit into from
Nov 28, 2023

Conversation

andrewlee94
Copy link
Member

@andrewlee94 andrewlee94 commented Nov 28, 2023 •
edited by github-actions bot
Loading

Title

Related to IDAES/idaes-pse#1292

Pyomo 6.7.0 added pre-checking for fixed variables which violate bounds in the solver writers which causes the current diagnostics example to fail (doe to a deliberate bounds violation in the demonstration). This PR removes that part of the example from the notebook.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--81.org.readthedocs.build/en/81/

@andrewlee94 andrewlee94 self-assigned this Nov 28, 2023
@andrewlee94 andrewlee94 added Priority:High High Priority Issue or PR bug Something isn't working labels Nov 28, 2023
jsiirola
jsiirola approved these changes Nov 28, 2023
View reviewed changes
Copy link

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but why are so many of the output cells changing? (Also, why are the execution numbers changing for diagnostics_toolbox_doc.ipynb?

@andrewlee94 andrewlee94 merged commit f5a535d into IDAES:main Nov 28, 2023
7 checks passed
@andrewlee94 andrewlee94 deleted the pyomo_6_7_bug branch November 28, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsiirola jsiirola jsiirola approved these changes

@blnicho blnicho Awaiting requested review from blnicho

@bpaul4 bpaul4 Awaiting requested review from bpaul4

Assignees

@andrewlee94 andrewlee94

Labels
bug Something isn't working Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlee94 @jsiirola