Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve failures in examples CI job by adding XFAIL pattern for new sco2 ALAMO surrogate examples #1345

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

Fixes

CI failures due to notebooks being added by IDAES/examples#69.

Changes proposed in this PR:

  • Add XFAIL pattern for new sco2 ALAMO surrogate examples

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Feb 19, 2024
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (063371a) 77.43% compared to head (308b6b9) 77.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
- Coverage   77.43%   77.43%   -0.01%     
==========================================
  Files         390      390              
  Lines       63758    63758              
  Branches    11737    11737              
==========================================
- Hits        49373    49370       -3     
- Misses      11841    11845       +4     
+ Partials     2544     2543       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 19, 2024
@lbianchi-lbl lbianchi-lbl merged commit b7548b9 into IDAES:main Feb 19, 2024
44 checks passed
@lbianchi-lbl lbianchi-lbl deleted the fix-examples-sco2-alamo branch February 19, 2024 23:47
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants