Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Fix google signin issue #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[HOTFIX] Fix google signin issue #471

wants to merge 1 commit into from
+29 −17

Conversation

lickem22
Copy link
Contributor

Reviewer:@amiraliemami
Estimate: 15mins

Ticket

Fixes:HOTFIX

Description

Goal

This PR fix the issue where the google sign in is not showing up on the login page.

Changes

Future Tasks (optional)

How has this been tested?

This PR has been testing locally and on app-testing, making sure it displays the button

To-do before merge (optional)

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

(Delete any items below that are not relevant)

  • I have updated the automated tests
  • I have updated the scripts in scripts/
  • I have updated the requirements
  • I have updated the README file
  • I have updated affected documentation
  • I have added a blogpost in Latest Updates
  • I have updated the CI/CD scripts in .github/workflows/
  • I have updated the Terraform code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidravi1 sidravi1 Awaiting requested review from sidravi1 sidravi1 is a code owner

@suzinyou suzinyou Awaiting requested review from suzinyou suzinyou is a code owner

@amiraliemami amiraliemami Awaiting requested review from amiraliemami amiraliemami is a code owner

@markbotterill markbotterill Awaiting requested review from markbotterill markbotterill is a code owner

@tonyzhao6 tonyzhao6 Awaiting requested review from tonyzhao6 tonyzhao6 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lickem22