Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

299 sdpi ri for r14 #302

Merged
merged 23 commits into from
Sep 17, 2024
Merged

299 sdpi ri for r14 #302

merged 23 commits into from
Sep 17, 2024

Conversation

ToddCooper
Copy link
Collaborator

@ToddCooper ToddCooper commented Aug 29, 2024

📑 Description

TF-1A Requirements Interoperability incremental update for SDPi release 1.4. Primary focus will be updates to the TF-1A section, both adding more detail to the Requirements Interoperability model + cleaning up content that is now dated (e.g., SysML 2.0 and MBSE ... both of which are valid but two years down the road, clearly not in the immediate future!).

☑ Mandatory Tasks

The following aspects have been respected by the pull request assignee and at least one reviewer:

  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer

Created place holder for the requirements glossary in the specification introduction section.
Updated the core requirements model (added IHE Profile) and some of the text in the subsequent table.
Incremental updates to the requirement documentation for IHE Profile & Tech Feature
@ToddCooper ToddCooper added the RI+MC+RR Related to requirements interoperability / model centric / regulatory ready label Aug 29, 2024
@ToddCooper ToddCooper added this to the SDPi 1.4 review milestone Aug 29, 2024
@ToddCooper ToddCooper self-assigned this Aug 29, 2024
@ToddCooper ToddCooper linked an issue Aug 29, 2024 that may be closed by this pull request
@ToddCooper
Copy link
Collaborator Author

@d-gregorczyk & @JavierEspina & @mfaughn :
For this release 1.4 incremental update to the requirements interoperability section of TF-1A, my thoughts are to:

  1. Remove the too aspirational appendix content (esp. MBSE and SysML ... these may be a simple note but not sections)
  2. Add detail to the metadata for each of the requirement types, with the current blocks providing a baseline
  3. Add a requirements labeling / numbering section that will then help developers & users understand how each block should be crafted and the metadata assigned.
  4. Craft an initial approach for linking requirements - @d-gregorczyk ... ideas? In AsciiDoc it is as simple as including <> anchor links, since we have those for every requirement; for JSON ... ? there are a few approaches like JSON-LD, JSON Reference, XLink, HAL ... (all from this blog entry)

We'll discuss tomorrow on our SDPi Friday call.

@mfaughn
Copy link
Collaborator

mfaughn commented Aug 29, 2024 via email

@ToddCooper
Copy link
Collaborator Author

@mfaughn ...

I think the short answer is, “Yes”…as long as you keep maintaining everything in a single .adoc file. If you have any aspirations of ever breaking this up into multiple pages (i.e., linking requirements acorss multiple AsciiDoc files) then make sure you understand the difference b/w how you do an internal cross reference and a document to document cross reference, especially what is documented herehttps://docs.asciidoctor.org/asciidoc/latest/macros/xref/. I don’t think the <> syntax works for interdocument cross references. If you go ahead and break things into several .adoc files and then use the xref macro to link them then you can choose to create everything as a single page using include statements or create multi-page output and it should still work

  1. we are not planning on breaking the SDPi supplement into multiple files BUT we do need the requirements to be differentiated BETWEEN different supplements and ultimately the mothership TF FT. We talked a long time ago about breaking the output into multiple page files - like FHIR-based stuff including IHE profiles like MHD - but that is a challenge with AsciiDoc & it is REALLY nice to have everything in one file so you can do a ctrl-f and find something anywhere in the spec!
  2. Requirements scope, though, does have to work beyond a single profile, since ultimately (initially with SDPi and PCIM profiles) they will get integrated into a single DEV TF "document".
  3. From my experiment, editing the MULTI AsciiDoc sources for the profile in the IntelliJ editor, when I did "<<r" a long list of requirements popped up including those from other source files (e.g., transactions). So I think we are good on the multi-source AsciiDoc files ... but @d-gregorczyk : Yes?

My real question was how we need to represent these relationships in the exported JSON file. We will have sufficient metadata included in the JSON export, BUT what is the best way to convert (?) these links? Remember that requirements interoperability includes being able to say that you have traceability from a high-level requirement (e.g., use case THEN clause) to where it is handled in the specification and ultimately the message element that would be tested. What does THAT look like in the JSON file?

(outta here for today ... fun discussion tomorrow morning!)

@ToddCooper
Copy link
Collaborator Author

SDPi Friday 2024.08.30 Review -
Group reviewed the above threads and the proposed 1.4 release work. Todd will update TF-1A for review in this PR..

Changes include:
1) removed editors note at top of appendix - no longer relevant
2) added descriptive detail to the hanging gardens model
3) added detail to the core requirements model & elements
4) "cleaned up" other areas that were either stale (deleted) or were incomplete
Testing both linking requirements from one AsciiDoc file to another AND documenting content export to JSON.
that was misinterpreted by the converter tool
Commented out most everything
remove reference to requirement in other file
Duplicated MDPWS requirement ... changed number ... work?
Added in the profile AIPO metadata
note and simple requirement test content
into the requirement block text
from TF-1A to TF-2A
@ToddCooper
Copy link
Collaborator Author

2024.08.30 Update -
Reworked TF-1A content, including additional metadata for the various requirement types (see core model).
Key questions remain:

  1. Requirement Usage - is this the best name? Perhaps Requirement Fulfillment or Fulfillment Capability? See related notes in the TF-1A section
  2. Representation of links in JSON: Is the <> sufficient?
  3. Requirements Integration - requires an IHE TF class model, to answer questions like what MUST an AIPO support? Is it sufficient to have parent-child requirements + "Requirement Fulfillment" capabilities pointing back the other way?

@ToddCooper ToddCooper marked this pull request as ready for review September 3, 2024 19:17
ToddCooper and others added 3 commits September 3, 2024 16:16
…#300) (#303)

* #152 Add discovery proxy transactions scaffold and actor description.

* #152 Add more content; add ack message to transaction sequence.

* #152 Tweak register message text

* #152 Add DEV-47, apply tweaks von DEV-46

* #152 Add DEV-47 probe and resolve

* #152 Various fixes

* #152 Various fixes

* #152 Add MDPWS binding contents for DEV-46

* #152 Add MDPWS binding contents for DEV-47; minor fixes to adhoc message excerpts

* #152 Add MDPWS binding contents to outline.

* #152 Fixes to DEV-47

* #152 Fixes to DEV-47

* Fix yml to use new versions of github action plugins

* Fix yml to use new versions of github action plugins

* #152 Update references to DEV-47 outlines

* Replace gradle-build-action with newer setup-gradle

* #152 Add discovery proxy sources and additional chapter

* Change path of setup-gradle@v3

* Use setup-gradle@v4

* Use setup-gradle@v4

* Use setup-gradle@v4

* #152 Fix findings

* DP Updates to TF-0 & TF-1 - Initial

Initial updates to add a transaction name to the TF-0 Transactions listing + the SDPi-P Actor model update & transaction table update & placeholder for the DP option description section.

* #152 Add discovery proxy basic sequence diagram

* #152 Enrich OID table caption in the discovery proxy section

* TF-1 Updates

Updated DP TF-1 content, specifically to the SDPi-P transaction table, the Actors and Options section (with its own table) and the Discovery Proxy Option section.

Content is rough but sufficient for discussion.

* Updated Sequence Diagram & Actor Diagram

Sequence Diagram - added secure groupings for all transactions
Actor Diagram - simplified to "Discovery Proxy"
Updated Change Log with #152 addition
A fix to the TF-1 SDPiP Transactions table to re-enable rendering of the end notes ... hopefully!

* Trying to Fix SDPi-P Transaction Table Notes

Notes are not appearing on last row of the transaction table.
Also changed the note numbering based on order from the top of the table.

* Fixed SDPi-P Transactions Table Notes

Found the extra vertical bar!

* Updated DP Transaction Names & PUML Diagram Titles & SDPi Transaction Table Updates

* Removed "SDPi" from many of the TF-2 transaction sequence diagram titles - transactions are not profile specific

* Refactored DEV-46 and DEV-47 transaction names + reference label text

* changed the DP transactions in the SDPi-P Actors & Transactions table to "O" vs. "C"

* Integrated comments from David's review of the option bullets

* Commented out the version text box from the options section but in the comments kept the potential future options,.

* Updated TF-1 DP Option Text

Converted the bulleted content into something readable and (generally) tagged.

* #152 Fix formatting

* #152 Fix formatting

* #152 Try to fix wrong directory for PUML includes in CI

* #152 Minor fixes

* #152 Add more space to images, tables and listings.

* Changed "SOMDS Discovery Proxy" to "Discovery Proxy"

Left over changes

* Editorial Updates based on review & DCC discussion

Numerous updates including ...
* removing "SOMDS" from "Discovery Proxy" actor name
* Discovery Proxy actor brief description more generic
* Use of "Transaction" for a specific transaction now uppercase "T"
* Managed Discovery Option renamed (from Discovery Proxy Option)
* Added "heartbeat" requirement for DP as part of managed discovery behaviour
Others ...

* Fixed PUML file name error

Refactoring PUML file name inserted a space in the file name ... !

* Fixed another file name error

Or didn't fix it previously?

* Highlighted "shall" statements for review & requirements block addition

#shall# added in option block to ensure review and either rewording, removal, or requirements block addition

* Updates to Discovery Proxy Option & DEV-47 Title

Changed include:
* Reset "Transaction" to lowercase "transaction" per guidance from Mary J.
* Simplified DEV-47 to "Retrieve Network Presence", leaving off "Metadata"
* Added requirements blocks for the option "shall" statements

* Transaction Description Updates + MD Option Updates

* Updated DEV-46 & DEV-47 transaction summaries to match the updated transaction names
* Added as a test, additional requirement metadata to the MD Option section
* Changed the arrow direction of the Bye() message for DEV-47

* Test of Inter-Requirement Links

Added forward / backward requirement anchor references to R1023.  fingers crossed

* Tweak update because workflow automation failed

2nd try at triggering build workflow

* Updates from SDPi Friday Review

Updates from review corrections.

---------

Co-authored-by: David Gregorczyk <[email protected]>
Integrated the master branch, including the Discovery Proxy content
Updated the TF-1A requirements model
Updates from TF-1A edits
Update for CHANGELOG.md
AsciiDoc labeling fix for "bibliography"
Pushed publication date to September 13
@ToddCooper ToddCooper removed a link to an issue Sep 13, 2024
@ToddCooper
Copy link
Collaborator Author

Removed link to #299 since it is only partially addressed in this 1.4 release

@ToddCooper ToddCooper linked an issue Sep 13, 2024 that may be closed by this pull request
ToddCooper and others added 5 commits September 13, 2024 12:24
Updated the versioning information (to review notes are not hard wired)
Updated change log
Expanded content in the TF-1A discussion
Changed the release date to verify that this branch can now be pushed (by Old Man Cooper)
First full pass through RI for 1.4 content.
@ToddCooper
Copy link
Collaborator Author

2024.09.16 - @d-gregorczyk @JavierEspina The content is now complete ... or as complete as it will be for this release 1.4. Please review and if ready-enough, Squash & Merge!

Copy link
Collaborator

@d-gregorczyk d-gregorczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caveat: I did not have time to thoroughly review the PR.

@ToddCooper ToddCooper merged commit 9b8ebe3 into master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RI+MC+RR Related to requirements interoperability / model centric / regulatory ready
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SDPi RI for R1.4
3 participants