Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Trace-Context #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

qligier
Copy link

@qligier qligier commented Feb 23, 2024

Closes #94

📑 Description

This PR adds two codes to the BasicAuditEntityType CodeSystem and the BasicAuditEntityTypesVS ValueSet: Traceparent and Tracestate. The slicing is updated, an exemple is modified to use traceparent instead of XrequestId and the documentation is updated accordingly.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • I have selected a committee co-chair to review the PR

ℹ Additional Information

@qligier
Copy link
Author

qligier commented Mar 15, 2024

Hi @JohnMoehrke! What do you think of this proposition? What would be the next step to fix the linked issue?

@JohnMoehrke
Copy link
Contributor

will add this to the next CP call.

@JohnMoehrke
Copy link
Contributor

CP-ITI-1303

@JohnMoehrke
Copy link
Contributor

There is interest, but the changes are big enough to require CP processing. The CP can refer to this Pull-Request, but the CP does need to be drafted with rational for the change.

@JohnMoehrke
Copy link
Contributor

@qligier can you prepare ITI-CP-1303 for a CP Ballot as discussed above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify tracing identifiers in AuditEvents
2 participants